-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default landing page #1293
Merged
Merged
Default landing page #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails query - Introduced landingPath attribute in UserGeneralPreferences and UserGeneralPreferencesInput types. - Updated UserDetails GraphQL query to include landingPath in user preferences. - Adjusted related GraphQL documents and generated types accordingly.
…ttings - Added userPreferenceLandingPaths to loader function for dynamic navigation. - Included paths for Fitness and Media entities using safe-routes. - Updated return value of loader to include userPreferenceLandingPaths.
…shboard settings - Changed userPreferenceLandingPaths from a Record to an array of objects for better organization. - Grouped paths under "Media" and "Fitness" categories for improved clarity and maintainability. - Removed JSON.stringify debug output from the Page component.
- Introduced a Select component for choosing the default landing page in user preferences. - Integrated with userPreferenceLandingPaths for dynamic options. - Updated landingPath in user preferences on selection change.
…erences - Added a redirectToLandingPath function to handle navigation based on user preferences. - Integrated search parameters schema for optional landing path redirection. - Updated dashboard layout to utilize the new forcedDashboardPath for consistent navigation.
- Eliminated redundant import of zod in the _dashboard._index.tsx file. - Ensured proper organization of imports for better code clarity.
…tions - Modified startOnboardingTour to be an async function for better handling of asynchronous operations. - Updated onClick handler in the Button component to await the startOnboardingTour function, ensuring proper execution flow.
- Moved forcedDashboardPath definition to common.tsx for centralized access. - Updated usage in general.tsx and _dashboard.tsx to utilize the new import, ensuring consistent navigation behavior across the application.
…alidation - Integrated user preferences and revalidation into the onboarding tour functionality. - Updated startOnboardingTour to modify user preferences for media and fitness features. - Ensured proper revalidation after updating user preferences to reflect changes immediately.
…age in preferences - Moved the Select component for choosing the default landing page within the preferences section to improve code organization. - Ensured the component retains its functionality and integrates seamlessly with user preferences.
IgnisDa
added a commit
that referenced
this pull request
Mar 18, 2025
* chore(models/user): add new general preference * feat(migrations): migrate default landing path to be dashboard * fix(migrations): correct landing path update in user preferences migration * feat(graphql): add landingPath to User preferences and update UserDetails query - Introduced landingPath attribute in UserGeneralPreferences and UserGeneralPreferencesInput types. - Updated UserDetails GraphQL query to include landingPath in user preferences. - Adjusted related GraphQL documents and generated types accordingly. * feat(frontend): enhance user preference landing paths in dashboard settings - Added userPreferenceLandingPaths to loader function for dynamic navigation. - Included paths for Fitness and Media entities using safe-routes. - Updated return value of loader to include userPreferenceLandingPaths. * fix(frontend): correct title in preferences meta for consistency * refactor(frontend): update userPreferenceLandingPaths structure in dashboard settings - Changed userPreferenceLandingPaths from a Record to an array of objects for better organization. - Grouped paths under "Media" and "Fitness" categories for improved clarity and maintainability. - Removed JSON.stringify debug output from the Page component. * feat(frontend): add default landing page selection to preferences - Introduced a Select component for choosing the default landing page in user preferences. - Integrated with userPreferenceLandingPaths for dynamic options. - Updated landingPath in user preferences on selection change. * feat(frontend): implement landing path redirection based on user preferences - Added a redirectToLandingPath function to handle navigation based on user preferences. - Integrated search parameters schema for optional landing path redirection. - Updated dashboard layout to utilize the new forcedDashboardPath for consistent navigation. * fix(frontend): remove duplicate zod import in dashboard index route - Eliminated redundant import of zod in the _dashboard._index.tsx file. - Ensured proper organization of imports for better code clarity. * ci: Run CI * fix(frontend): update onboarding tour function to support async operations - Modified startOnboardingTour to be an async function for better handling of asynchronous operations. - Updated onClick handler in the Button component to await the startOnboardingTour function, ensuring proper execution flow. * feat(frontend): refactor forcedDashboardPath for consistent navigation - Moved forcedDashboardPath definition to common.tsx for centralized access. - Updated usage in general.tsx and _dashboard.tsx to utilize the new import, ensuring consistent navigation behavior across the application. * feat(frontend): enhance onboarding tour with user preferences and revalidation - Integrated user preferences and revalidation into the onboarding tour functionality. - Updated startOnboardingTour to modify user preferences for media and fitness features. - Ensured proper revalidation after updating user preferences to reflect changes immediately. * ci: Run CI * refactor(frontend): reposition Select component for default landing page in preferences - Moved the Select component for choosing the default landing page within the preferences section to improve code organization. - Ensured the component retains its functionality and integrates seamlessly with user preferences. Implement server key validation for landing page preference updates
IgnisDa
added a commit
that referenced
this pull request
Mar 18, 2025
* chore(models/user): add new general preference * feat(migrations): migrate default landing path to be dashboard * fix(migrations): correct landing path update in user preferences migration * feat(graphql): add landingPath to User preferences and update UserDetails query - Introduced landingPath attribute in UserGeneralPreferences and UserGeneralPreferencesInput types. - Updated UserDetails GraphQL query to include landingPath in user preferences. - Adjusted related GraphQL documents and generated types accordingly. * feat(frontend): enhance user preference landing paths in dashboard settings - Added userPreferenceLandingPaths to loader function for dynamic navigation. - Included paths for Fitness and Media entities using safe-routes. - Updated return value of loader to include userPreferenceLandingPaths. * fix(frontend): correct title in preferences meta for consistency * refactor(frontend): update userPreferenceLandingPaths structure in dashboard settings - Changed userPreferenceLandingPaths from a Record to an array of objects for better organization. - Grouped paths under "Media" and "Fitness" categories for improved clarity and maintainability. - Removed JSON.stringify debug output from the Page component. * feat(frontend): add default landing page selection to preferences - Introduced a Select component for choosing the default landing page in user preferences. - Integrated with userPreferenceLandingPaths for dynamic options. - Updated landingPath in user preferences on selection change. * feat(frontend): implement landing path redirection based on user preferences - Added a redirectToLandingPath function to handle navigation based on user preferences. - Integrated search parameters schema for optional landing path redirection. - Updated dashboard layout to utilize the new forcedDashboardPath for consistent navigation. * fix(frontend): remove duplicate zod import in dashboard index route - Eliminated redundant import of zod in the _dashboard._index.tsx file. - Ensured proper organization of imports for better code clarity. * ci: Run CI * fix(frontend): update onboarding tour function to support async operations - Modified startOnboardingTour to be an async function for better handling of asynchronous operations. - Updated onClick handler in the Button component to await the startOnboardingTour function, ensuring proper execution flow. * feat(frontend): refactor forcedDashboardPath for consistent navigation - Moved forcedDashboardPath definition to common.tsx for centralized access. - Updated usage in general.tsx and _dashboard.tsx to utilize the new import, ensuring consistent navigation behavior across the application. * feat(frontend): enhance onboarding tour with user preferences and revalidation - Integrated user preferences and revalidation into the onboarding tour functionality. - Updated startOnboardingTour to modify user preferences for media and fitness features. - Ensured proper revalidation after updating user preferences to reflect changes immediately. * ci: Run CI * refactor(frontend): reposition Select component for default landing page in preferences - Moved the Select component for choosing the default landing page within the preferences section to improve code organization. - Ensured the component retains its functionality and integrates seamlessly with user preferences. Implement server key validation for landing page preference updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1292.