Correct equality check for committing person (#1227)

* chore(services/misc): add correct log * chore(frontend): change the label of select item * fix(utils/dependent): handle query for commit person correctly * chore(utils/dependent): remove useless `println!`
IgnisDa · Feb 1, 2025 · 5dcec14 · 5dcec14
1 parent 20d1d82
commit 5dcec14
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/apps/frontend/app/routes/_dashboard.fitness.exercises.$action.tsx b/apps/frontend/app/routes/_dashboard.fitness.exercises.$action.tsx
@@ -193,9 +193,12 @@ export default function Page() {
 						required
 						name="lot"
 						label="Type"
-						data={Object.values(ExerciseLot)}
 						defaultValue={loaderData.details?.lot}
 						readOnly={loaderData.action === Action.Update}
+						data={Object.values(ExerciseLot).map((l) => ({
+							value: l,
+							label: startCase(l.toLowerCase()),
+						}))}
 					/>
 					<Group wrap="nowrap">
 						<Select

diff --git a/crates/services/miscellaneous/src/lib.rs b/crates/services/miscellaneous/src/lib.rs
@@ -2867,7 +2867,7 @@ ORDER BY RANDOM() LIMIT 10;
 
         ryot_log!(trace, "Invalidating invalid media import jobs");
         self.invalidate_import_jobs().await.trace_ok();
-        ryot_log!(trace, "Checking for updates for media in Watchlist");
+        ryot_log!(trace, "Checking for updates for monitored media");
         self.update_monitored_metadata_and_queue_notifications()
             .await
             .trace_ok();

diff --git a/crates/utils/dependent/src/lib.rs b/crates/utils/dependent/src/lib.rs
@@ -782,8 +782,9 @@ pub async fn commit_person(
     match Person::find()
         .filter(person::Column::Source.eq(input.source))
         .filter(person::Column::Identifier.eq(&input.identifier))
-        .apply_if(input.source_specifics.clone(), |query, v| {
-            query.filter(person::Column::SourceSpecifics.eq(v))
+        .filter(match input.source_specifics.clone() {
+            None => person::Column::SourceSpecifics.is_null(),
+            Some(specifics) => person::Column::SourceSpecifics.eq(specifics),
         })
         .one(db)
         .await?