Work around lldb python issues #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
TingPing
requested changes
Feb 17, 2025
| user_home=$(getent passwd "${container_user_name}" | cut -d: -f6) | ||
|
|
||
| sudo apt install lsb-release wget software-properties-common gnupg -y | ||
| wget -qO - https://apt.llvm.org/llvm.sh | sudo bash -s 19 -y |
There was a problem hiding this comment.
- Installing core packages doesn't belong in
.wkdev-init, it would go in the dockerfile. - Downloading and installing the entire llvm toolchain is a pretty massive change... Can you not get Ubuntu's LLVM 18 working?
FWIW, I use the LLDB integration in VSCode every day without issue.
There was a problem hiding this comment.
I agree, we should try to use the LLVM bundled with Ubuntu and find out the root cause of the issue. @justinmichaud wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the python installation to work with lldb scripts in the WebKit repo, like dump-class-layout.