Install VSCodium and make host .application file #86
Conversation
justinmichaud
commented
Jan 16, 2025
justinmichaud
commented
- Work around lldb python issues
- Install VSCodium by default
- Add helpful clangd default settings
- Make VSCode .application file by default
| "editorWhitespace.background": "#FF0000" | ||
| }, | ||
| "terminal.integrated.allowChords": false, | ||
| } |
There was a problem hiding this comment.
Some of these are pretty arbitrary. I like the clangd.arguments but maybe lets move this to a different PR to discuss.
There was a problem hiding this comment.
The clangd and fg/bg colours are important for our style guidelines, but I removed the rest.
There was a problem hiding this comment.
Oh you just mean to more easily visualize whitespace.
I've never needed that and don't think I'd want it by default. I'll check how it looks.
There was a problem hiding this comment.
I'm going to vote no on this, I think it would annoy most people.
There was a problem hiding this comment.
Oh shoot, it doesn't look like that for me. It is only supposed to display trailing whitespace
There was a problem hiding this comment.
Some other setting is involved. It would be best to keep these PRs small, I'd remove this change here and it can be discussed on its own.
justinmichaud
force-pushed
the
vscodium-xdg
branch
from
728c692 to
f5cd9f4
Compare
|
Thank you for the review, everything has been updated! |
- Add helpful clangd default settings - Make VSCode .application file by default
justinmichaud
force-pushed
the
vscodium-xdg
branch
from
f5cd9f4 to
3e1d171
Compare
| install_extension() { | ||
|
|
||
| sudo chown "${USER}" "${HOME}/.config" |
There was a problem hiding this comment.
How would .config be owned by a different user?
There was a problem hiding this comment.
Maybe this was an idiosyncrasy of my setup, let's remove it and see if it comes up again
There was a problem hiding this comment.
This is needed if you run this script from your firstrun script. It seems it runs as root. I guess I can change my firstrun script to run as the container user
There was a problem hiding this comment.
What I said makes no sense, since we use $USER here
There was a problem hiding this comment.
It looks like systemd makes the config path? At the very least, some files in ~/.config/systemd appear to be owned by root.
There was a problem hiding this comment.
Yeah, this is confusing to me, although .config is definitely owned by root. In particular, so is .config/systemd, which seems to come from nowhere. Do you have any ideas how I can start debugging this?
There was a problem hiding this comment.
I'm not certain, but I cannot reproduce this:
> wkdev-create --home=$HOME/wkdev-testing --create-home
> ls -lah ~/wkdev-testing/
total 16K
drwxr-x---. 1 tingping tingping 110 Feb 5 11:52 ./
drwx------. 1 tingping tingping 2.5K Feb 5 11:52 ../
-rw-r--r--. 1 tingping tingping 18 Feb 5 11:52 .bash_logout
-rw-r--r--. 1 tingping tingping 144 Feb 5 11:52 .bash_profile
-rw-r--r--. 1 tingping tingping 522 Feb 5 11:52 .bashrc
drwxr-xr-x. 1 tingping tingping 8 Feb 5 11:52 .config/
-rw-r--r--. 1 tingping tingping 168 Feb 5 11:52 .gdbinit
drwxr-xr-x. 1 tingping tingping 34 Feb 5 11:52 .mozilla/
> ls -lah ~/wkdev-testing/.config/
total 0
drwxr-xr-x. 1 tingping tingping 8 Feb 5 11:52 ./
drwxr-x---. 1 tingping tingping 110 Feb 5 11:52 ../
drwxr-xr-x. 1 tingping tingping 22 Feb 5 11:52 fish/
The fact .mozilla exists is interesting. There must be some template being copied for a new users home.
There was a problem hiding this comment.
Ah, from here:
# Copy shell configuration skeleton files from host.
cp --recursive --verbose /etc/skel "${container_user_home}"
# Set ownership / permissions
chown ${container_user_id}:${container_group_id} "${container_user_home}"
chmod 750 "${container_user_home}"
default_config_directory="$(get_container_home_defaults_directory_name)"
shell_type=$(basename "${SHELL}")
mkdir --parents "${container_user_home}"/.config
| Name=VSCode WKDev | ||
| Comment=Code Editing. Redefined. | ||
| GenericName=Text Editor | ||
| Exec="${WKDEV_SDK_HOST}/scripts/host-only/wkdev-enter" --exec --no-interactive -- $CODE_EXEC %F |
There was a problem hiding this comment.
This doesn't quite work, we need to set WKDEV_SDK
