Skip to content

Commit

Permalink
wpewebkit: tweak runtime dependencies/recommendations
Browse files Browse the repository at this point in the history
The remote inspector support has a hard requirement on the plugin, and
the plugin hard-requires shared-mime-info or otherwise resources served
by the remote inspector won't include a Content-Type header and the
client will fail to load them.

Reflect the above by making wpewebkit-web-inspector-plugin have a
runtime dependency on shared-mime-info, and then making wpewebkit depend
on wpewebkit-web-inspector-plugin when remote-inspector is enabled in
PACKAGECONFIG.
  • Loading branch information
aperezdc authored and psaavedra committed Oct 27, 2021
1 parent 73fbd3e commit 74b6820
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions recipes-browser/wpewebkit/wpewebkit.inc
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ ARM_INSTRUCTION_SET_armv7ve = "thumb"
RDEPENDS_${PN} += " \
libgles2 \
virtual/wpebackend \
${@bb.utils.contains('PACKAGECONFIG', 'remote-inspector', '${PN}-web-inspector-plugin', '', d)} \
${@bb.utils.contains('PACKAGECONFIG', 'mediasource', 'gstreamer1.0-plugins-good-isomp4', '', d)} \
${@bb.utils.contains('PACKAGECONFIG', 'webaudio', 'gstreamer1.0-plugins-good-wavparse', '', d)} \
${@bb.utils.contains('PACKAGECONFIG', 'gst_gl', 'gstreamer1.0-plugins-base-opengl', '', d)} \
Expand All @@ -160,14 +161,16 @@ RDEPENDS_${PN} += " \
', '', d)} \
"

RDEPENDS_${PN}-web-inspector-plugin += " \
shared-mime-info \
"

# Extra runtime recommends
RRECOMMENDS_${PN} += " \
ca-certificates \
shared-mime-info \
ttf-dejavu-sans \
ttf-dejavu-sans-mono \
ttf-dejavu-serif \
${PN}-web-inspector-plugin \
${PN}-qtwpe-qml-plugin \
${@bb.utils.contains('PACKAGECONFIG', 'video', 'gstreamer1.0-plugins-base-meta gstreamer1.0-plugins-good-meta gstreamer1.0-plugins-bad-meta', '', d)} \
"

0 comments on commit 74b6820

Please sign in to comment.