Skip to content

ignore tests in djangosaml2 package too#428

Open
prauscher wants to merge 4 commits intoIdentityPython:masterfrom
prauscher:427-no-tests-in-package
Open

ignore tests in djangosaml2 package too#428
prauscher wants to merge 4 commits intoIdentityPython:masterfrom
prauscher:427-no-tests-in-package

Conversation

@prauscher
Copy link
Contributor

closes #427 - see issue for more details.

As this project supplies tests in both the tests and djangosaml2.tests packages, we need to ignore both of them and also remove the docs-module, which currently only contains header.html and footer.html in the final package.

Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prauscher the ci fails

I have tò ask you tò fix that before consider this ready for the merge

@prauscher prauscher force-pushed the 427-no-tests-in-package branch from 903f6d0 to a30b69d Compare February 18, 2026 20:16
@prauscher
Copy link
Contributor Author

Okay, I'm sorry, but my understanding of tox lacks way behind of what is needed for this. Additionally I cannot offer time to fix the tests. From what I see the problem should be at DJANGO_SETTINGS_MODULE in tests/run_tests.py and similar lines in djangosaml2/tests/__init__.py: As tox seems to only use the generated package (which does not contain the tests with this PR), tests seem to fail at getting the settings module.

If anyone feels like bringing this forward I'd be grateful, otherwise this PR should probably be closed, sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Tests from built Package

2 participants

Comments