Fix password replacement for unsubmitted and unsaved forms #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncosta-ic
force-pushed
the
feature/password-dummy-toggle
branch
from
c22a7be to
cf3e08e
Compare
ncosta-ic
changed the title
ncosta-ic
force-pushed
the
feature/password-dummy-toggle
branch
from
cf3e08e to
74bc2a3
Compare
ncosta-ic
requested review from
nilmerg
and removed request for
sukhwinder33445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The password replacement should not get triggered on unsubmitted forms and on forms that have not been persisted yet (which gets caused by autosubmits, validations, etc...).
@nilmerg I kept the validity check as it would break #57 (comment) when removed. It still works as expected. Adding and saving a new transport command with wrong credentials still suppresses the password replacement.
Resolves: Icinga/icinga-notifications-web#224