-
Notifications
You must be signed in to change notification settings - Fork 598
SELinux: allow logrotate to execute icinga2 binary
#10621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Tested, works fine and causes no other SELinux denials! |
|
Given |
No, as already pointed out in #10527 (comment), that has no effect on postrotate (and other script commands). |
julianbrost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks sane and also worked on my test machine.
|
Please do not merge :). Would be nice if #10582 would be merged first, so that it can automatically backport it to the 2.15 support branch. |
|
Huh? That shouldn't be related to merging the original PR? Shouldn't it be possible to trigger a backport after the PR was merged? |
Not at the moment. Currently it only supports the |
With the last security releases #10530 changed the logrotate config to use the
icinga2 internal signalcommand to send theUSR1signal to the umbrella process, resulting rightfully in SELinux denials since this a confined executable. This PR allows thelogrotate_tdomain to be able to execute that bianry file. This might cause other SELinux deinials if theicinga2 internalcommand opens/reads some other Icinga 2 config files, but I'll test it tomorrow and share the results here.fixes #10616