Apply Minimum correctly to individual HTTPStatus-Checks #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Minimum
Parameter ofInvoke-IcingaCheckHTTPStatus
supposedly (there is not much documentation) allows one to define how many sub checks must be OK for the main check to be OK.I did assume that this meant each individual URL given (e.g.
Invoke-IcingaCheckHTTPStatus -URL https://foo.bar,https://bar.foo,https://baz.baz -Minimum 2
would be OK if checks fail for one URL but not for two) and changed to logic in the plugin accordingly.If that is not the case and the parameter was meant for sub checks regarding each individual URL I would propose another parameter which does what I think :-)
ref NC/849479