Skip to content

ContactGroupsController: Show add contact link if no contact exists #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jun 23, 2025

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jun 23, 2025
@sukhwinder33445 sukhwinder33445 self-assigned this Jun 23, 2025
@sukhwinder33445
Copy link
Contributor Author

Case : There is only one contact available, and there is also a contact group containing this contact.

When the user deletes the contact, should the contactgroup also be deleted? Because the contact group now has no members and the modal Edit contact group again shows no suggestion (in contactgroup detail view).

@flourish86
Copy link
Contributor

It works great. But we should also handle the case, when the user has no channels either, shouldn't we?

In this case user won't be able to create a contact via the second column. I will come up with something soon …

@sukhwinder33445
Copy link
Contributor Author

We can display a kind of wizard when the user activates the module for the first time to show these steps (channel, contact). Same as the setup wizard in Icingaweb.

@flourish86
Copy link
Contributor

flourish86 commented Jul 1, 2025

I thought of something like this for the case when there's neither channels nor contacts configured. A wizard could be an additional feature to onboard user.

For the empty state warnings, there's still the use case, when channels or contacts are deleted in hindsight.

And another thing: The empty state statement still reads "No contacts found.", even for contact groups, it should be "No contact groups found."

Frame 70

In this example the user …

  1. opens channels in the second column
  2. save channel and closes the column
  3. then adds the contact
  4. saves and closes it
  5. can now create the contact group

- ContactsContoller: Closing the container is sufficient.
@sukhwinder33445 sukhwinder33445 force-pushed the feature/show-msg-when-no-contact-available branch from bc29c37 to f3a7fcf Compare July 1, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Groups: Prevent users from trying to create a contact group, when there are no contacts
2 participants