Improve ContactForm #301

sukhwinder33445 · 2025-02-17T19:21:02Z

resolves #276, #74

Requires:

nilmerg · 2025-07-25T05:56:31Z

application/controllers/ChannelsController.php

@@ -112,7 +112,7 @@ public function addAction()
                        $form->getValue('name')
                    )
                );
-                $this->redirectNow(Links::channels());
+                $this->redirectNow('__CLOSE__');


Suggested change

$this->redirectNow('__CLOSE__');

$this->switchToSingleColumnLayout();

nilmerg · 2025-07-25T06:03:37Z

application/controllers/ContactsController.php

+                TemplateString::create(
+                    $this->translate(
+                        'No contacts found. To add a new contact, please {{#link}}configure a Channel{{/link}} first.'
+                        .' A default channel is required for the contact.'


What is the reasoning to include?:

A default channel is required for the contact.

The time the contact form first appears, this message is gone and the user forgot what it mentioned because he had to click on Add Contact first to actually see the form.

To me, it just adds complexity to the message.

nilmerg · 2025-07-25T06:30:40Z

library/Notifications/Web/Form/ContactForm.php

+                    "Link existing Icinga Web users. Users from external authentication backends"
+                    . " won't be suggested and must be entered manually."


We add a description now, but don't explain what the purpose is to link Icinga Web users? Missed opportunity, I'd say.

nilmerg · 2025-07-25T06:42:22Z

public/css/form.less

+  }
+
+  input.search {
+    padding-left: 1.5em; // property was overwritten .icinga-controls


Without an icon, this padding serves no purpose. Plus, if we really want the icon, this should be standardized somewhat, so a new element type or behavior (completion) should be provided by ipl-web.

nilmerg · 2025-07-25T06:43:44Z

library/Notifications/Web/Form/ContactForm.php

+                "Contact will be notified via the default channel, when no specific channel is configured"
+                . " in a schedule or event rule"


Sometimes there's a trailing period, sometimes not. Please clean that up, so all descriptions have one.

nilmerg · 2025-07-25T06:50:03Z

library/Notifications/Web/Form/ContactForm.php

            ]
        );

-        $this->addAddressElements();
+        $this
+            ->registerElement($defaultChannel)


If you'd register this in the fieldset, you don't have to move the value back and forth later on.

nilmerg · 2025-07-25T06:53:30Z

public/css/form.less

+  fieldset[name="contact_address"] {
+    padding-bottom: 1em;
+    border-bottom: 1px solid @gray-light;
+  }


Please use an hr element instead.

nilmerg · 2025-07-25T07:00:23Z

public/css/form.less

+.icinga-form p.description {
+  color: @text-color-light;
+
+  &:last-child { // fieldset > .control-group:last-of-type rule unset the last element's bottom margin


If it only applies to fieldsets, then please make sure this rule does so as well!

nilmerg · 2025-07-25T07:01:52Z

public/css/form.less

+  }
+}
+
+.icinga-form p.description {


form p.description should suffice.

nilmerg · 2025-07-25T07:02:55Z

library/Notifications/Widget/IcingaWebUserSuggestions.php

+
+            if ($backend instanceof DomainAwareInterface) {
+                $names = array_map(function ($name) use ($backend) {
+                    return $name . '@' . $backend->getDomain();


As the element `default_channel_id` is no longer part of the field set `contact`, it must be handled accordingly

…equired` AvailableChannelType: Make channel a left join relation

ContactControler: Add suggestion action and cleanup code

- ChannelsContoller: Closing the container is sufficient.

sukhwinder33445 self-assigned this Feb 17, 2025

cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Feb 17, 2025

sukhwinder33445 marked this pull request as draft February 17, 2025 19:21

sukhwinder33445 mentioned this pull request Feb 20, 2025

ContactForm: Make selected default channel's address field required #284

Closed

sukhwinder33445 force-pushed the improve-contact-form branch from a024ca5 to 9ceb4f8 Compare February 20, 2025 12:16

sukhwinder33445 requested a review from ncosta-ic February 20, 2025 15:07

sukhwinder33445 marked this pull request as ready for review February 20, 2025 15:07

sukhwinder33445 force-pushed the improve-contact-form branch 2 times, most recently from 8c775fd to ffe680c Compare February 21, 2025 08:58

sukhwinder33445 force-pushed the improve-contact-form branch from ffe680c to 8ef7576 Compare April 7, 2025 13:22

sukhwinder33445 force-pushed the improve-contact-form branch 4 times, most recently from afe1b01 to 65928a3 Compare May 8, 2025 11:48

sukhwinder33445 requested a review from nilmerg May 9, 2025 09:12

sukhwinder33445 force-pushed the improve-contact-form branch 3 times, most recently from 15afc4c to c57238f Compare May 15, 2025 11:21

sukhwinder33445 linked an issue Jul 23, 2025 that may be closed by this pull request

ContactForm: Selected default channel element must be required #74

Open

sukhwinder33445 removed the request for review from ncosta-ic July 23, 2025 11:21

nilmerg requested changes Jul 25, 2025

View reviewed changes

ContactForm: Improve labels of form elements

d4551ee

sukhwinder33445 mentioned this pull request Jul 25, 2025

ChannelForm: Show message intead of stacktrace when no channel type found #290

Open

sukhwinder33445 added 2 commits July 25, 2025 16:50

ContactForm: Add description to channels fieldset

2e67c3c

ContactFrom: Add Default channel element as last form element

8b38e6c

As the element `default_channel_id` is no longer part of the field set `contact`, it must be handled accordingly

sukhwinder33445 force-pushed the improve-contact-form branch from c57238f to dfe35cc Compare July 29, 2025 10:47

sukhwinder33445 requested a review from nilmerg July 29, 2025 11:46

sukhwinder33445 force-pushed the improve-contact-form branch 2 times, most recently from b765153 to 251fde3 Compare July 29, 2025 12:17

sukhwinder33445 removed the request for review from nilmerg July 29, 2025 12:21

sukhwinder33445 added 5 commits July 29, 2025 14:40

ContactForm: Make address field of seleted default channel element `r…

d705dc3

…equired` AvailableChannelType: Make channel a left join relation

ContactForm: Add description for user and default_channel element

58a6845

ContactForm: Show suggestions while typing in user element

b4c71c7

ContactControler: Add suggestion action and cleanup code

forms.less: Add .description color and margin

0116dc7

ContactsController: Show add channel link if no channel exists

89f0630

- ChannelsContoller: Closing the container is sufficient.

sukhwinder33445 force-pushed the improve-contact-form branch from 251fde3 to 89f0630 Compare July 29, 2025 12:42

sukhwinder33445 requested a review from nilmerg July 29, 2025 12:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve ContactForm #301

Improve ContactForm #301

Uh oh!

sukhwinder33445 commented Feb 17, 2025 •

edited

Loading

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

sukhwinder33445 Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

nilmerg Jul 25, 2025

Uh oh!

Uh oh!

	$this->redirectNow('__CLOSE__');
	$this->switchToSingleColumnLayout();

		"Link existing Icinga Web users. Users from external authentication backends"
		. " won't be suggested and must be entered manually."

		"Contact will be notified via the default channel, when no specific channel is configured"
		. " in a schedule or event rule"

Improve ContactForm #301

Are you sure you want to change the base?

Improve ContactForm #301

Uh oh!

Conversation

sukhwinder33445 commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requires:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sukhwinder33445 commented Feb 17, 2025 •

edited

Loading