Improve ContactForm #301
Open
Improve ContactForm #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
improve-contact-form
branch
from
a024ca5 to
9ceb4f8
Compare
sukhwinder33445
force-pushed
the
improve-contact-form
branch
2 times, most recently
from
8c775fd to
ffe680c
Compare
sukhwinder33445
force-pushed
the
improve-contact-form
branch
from
ffe680c to
8ef7576
Compare
sukhwinder33445
force-pushed
the
improve-contact-form
branch
4 times, most recently
from
afe1b01 to
65928a3
Compare
sukhwinder33445
force-pushed
the
improve-contact-form
branch
3 times, most recently
from
15afc4c to
c57238f
Compare
nilmerg
requested changes
Jul 25, 2025
sukhwinder33445
force-pushed
the
improve-contact-form
branch
from
c57238f to
dfe35cc
Compare
sukhwinder33445
force-pushed
the
improve-contact-form
branch
2 times, most recently
from
b765153 to
251fde3
Compare
sukhwinder33445
force-pushed
the
improve-contact-form
branch
from
251fde3 to
89f0630
Compare
sukhwinder33445
force-pushed
the
improve-contact-form
branch
from
89f0630 to
78ee1fa
Compare
nilmerg
requested changes
Aug 8, 2025
| 'p', | ||
| new Attributes(['class' => 'description']), | ||
| new Text($this->translate( | ||
| 'Add an Icinga Web user to associate with this contact. Users from external authentication' |
There was a problem hiding this comment.
Sorry, but Add an Icinga Web user to associate with this contact. and Link existing Icinga Web users. both describe the same outcome.
Use this:
Use this to associate actions in the UI, such as incident management, with this contact. To successfully receive desktop notifications, this is also required.
|
|
||
| foreach ($names as $name) { | ||
| yield [ | ||
| 'search' => $name . $domain, |
There was a problem hiding this comment.
phpstan:
Binary operation "." between mixed and non-falsy-string|null results in an error.
sukhwinder33445
force-pushed
the
improve-contact-form
branch
2 times, most recently
from
16a7cc6 to
9ad0992
Compare
As the element `default_channel_id` is no longer part of the field set `contact`, it must be handled accordingly
…equired` AvailableChannelType: Make channel a left join relation
ContactControler: Add suggestion action and cleanup code
- ChannelsContoller: Closing the container is sufficient.
sukhwinder33445
force-pushed
the
improve-contact-form
branch
from
9ad0992 to
d4c76d9
Compare
sukhwinder33445
requested review from
nilmerg
and removed request for
nilmerg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #276, #74
Requires:
.action-linkandbutton-linkcss icingaweb2#5370SuggestionElementipl-web#305