Schedules: Add timescale and time indicator #292
Conversation
sukhwinder33445
force-pushed
the
add-timescale-and-indicator
branch
4 times, most recently
from
62d68b8 to
505ac04
Compare
sukhwinder33445
force-pushed
the
add-timescale-and-indicator
branch
from
505ac04 to
8ea7052
Compare
| use ipl\Web\Style; | ||
| use Locale; | ||
|
|
||
| class Timescale extends BaseHtmlElement |
There was a problem hiding this comment.
The class documentation is missing (PHPDoc)
| $allTimestamps = array_merge(...array_fill(0, $this->days, $dayTimestamps)); | ||
|
|
||
| $lastPosition = count($allTimestamps) - 1; | ||
|
|
||
| $fakeLast = clone $allTimestamps[$lastPosition]; | ||
| $allTimestamps[$lastPosition] = $fakeLast->addAttributes(['class' => 'last']); | ||
| // added the class to add them into the same cell | ||
| $first = clone $allTimestamps[0]; | ||
| $allTimestamps[] = $first->addAttributes(['class' => 'midnight']); |
There was a problem hiding this comment.
Maybe a description would be helpful as to why the clones are needed (array_fill works with references and fills the array positions with references to the same $dayTimestamps array, changing something on its contents, changes it in all positions).
| new HtmlElement( | ||
| 'div', | ||
| new Attributes(['class' => 'now', 'title' => $dateFormatter->format($now)]), | ||
| Text::create('now') |
There was a problem hiding this comment.
This is missing a translation
|
@sukhwinder33445 I've also noticed that something's off in Firefox. While the timeline and grid render correctly, the timescale's off. It's especially noticeable when using the monthly view. |
sukhwinder33445
force-pushed
the
add-timescale-and-indicator
branch
2 times, most recently
from
0384a27 to
a40eb0f
Compare
There was a problem hiding this comment.
Looks fine so far.
There're one thing I noticed, though.
The cursor is inapporpriate in this case, since there's nothing happening on click.
The scale labels still look cluttered especially in month and 2 weeks mode. But we should postpone the refinement to another time.
sukhwinder33445
force-pushed
the
add-timescale-and-indicator
branch
from
a40eb0f to
fead6e6
Compare
|
Firefox still has problems (@flourish86 and @nilmerg say it's not that important), but Safari and Chrome work perfectly now. |
public/css/timeline.less
Outdated
| background-color: @gray-light; | ||
| font-size: 0.75em; | ||
| color: red; | ||
| user-select: none; |
There was a problem hiding this comment.
I found, that it won't work on Safari and a Quick Look here shows, that you probably need the prefixes for all browsers to make this work.
So I'd suggest to add
-webkit-user-select: none;
-moz-user-select: none;
and optionally
-ms-user-select: none;
There was a problem hiding this comment.
Ahmm, fortunately we have a mixin for that.
There was a problem hiding this comment.
Safari disables the selection, but still shows the caret cursor 🤦.
sukhwinder33445
force-pushed
the
add-timescale-and-indicator
branch
from
fead6e6 to
66923ce
Compare
sukhwinder33445
force-pushed
the
add-timescale-and-indicator
branch
from
66923ce to
9f54900
Compare
sukhwinder33445
force-pushed
the
add-timescale-and-indicator
branch
from
9f54900 to
5d70ce3
Compare
resolves #283