Add different view modes for resource lists #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoxhaa
suggested changes
Jan 13, 2025
|
I've updated the PR description to show the main changes. I think there's nothing specific that requires extra attention. |
jhoxhaa
suggested changes
Jan 14, 2025
There was a problem hiding this comment.
Please use only one class instead of three (*ListItem, *ListItemMinimal, *ListItemDetailed) to handle the different levels of detail for displaying resource information.
Also use the ViewMode trait in the BaseItemList.php and BaseItemList.php instead of using it in all the other List classes.
|
I placed the constants in ViewModeSwitcher instead, because I think they fit better there. |
jrauh01
force-pushed
the
viewmodes
branch
2 times, most recently
from
ea8dcfc to
3f467af
Compare
jhoxhaa
suggested changes
Jan 15, 2025
jhoxhaa
approved these changes
Jan 16, 2025
jhoxhaa
suggested changes
Jan 16, 2025
jhoxhaa
approved these changes
Jan 16, 2025
jrauh01
force-pushed
the
viewmodes
branch
2 times, most recently
from
4686cda to
9104821
Compare
Pass database via argument to fetchResource() instead of creating a new connection for each loop pass what can lead to an 'Too many connections' error.
Show footer instead of caption for `Secrets`.
... to provide a base to render resources.
Add SidecarContainers and InitContainers and return pvc for PersistentVolumeClaims
lippserd
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new view modes for resource lists to enhance the user experience, following the approach used in icingadb-web. The implemantation includes three view modes:
If a resource does not provide sufficient information for a more detailed view, the corresponding options in the view mode switcher will not be available.
Closes #136