Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto defer #223

Closed
wants to merge 3 commits into from
Closed

Implement auto defer #223

wants to merge 3 commits into from

Conversation

Lulalaby
Copy link

@Lulalaby Lulalaby commented Nov 10, 2022

I'm not sure if I did it correctly. Open for feedback ❤️

Closes #222

@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interaction-kit ✅ Ready (Inspect) Visit Preview Nov 13, 2022 at 6:10AM (UTC)

@IanMitchell
Copy link
Owner

Oh interesting, I had been thinking of adding it at the command / component level, but this is probably better yeah. I will do a deeper review when I have time, the badge launch has me a lil busy sorry!

@Lulalaby
Copy link
Author

Always the badges smh Mr. Active Developer Badge 🤣

@ckohen
Copy link
Collaborator

ckohen commented Nov 13, 2022

I also thought it would be on a per-command level like Ian said. I do like this, but maybe there should be an option to individually change it for some where you might not want to auto defer.

@Lulalaby
Copy link
Author

I also thought it would be on a per-command level like Ian said. I do like this, but maybe there should be an option to individually change it for some where you might not want to auto defer.

Something like ignore global setting?

@IanMitchell
Copy link
Owner

I'd say add an auto defer option to commands as well, and let them set it to true/false. Easy to add or remove per command that way, and change it for all for reduced boilerplate. Best of both worlds

@Lulalaby
Copy link
Author

okidoki, will do tmrw

@Lulalaby
Copy link
Author

Lulalaby commented Sep 4, 2023

I wish I could finish it but I just don't have the time, so closing it. Maybe someone else would like to add it (I still think it'd be a cool feature)

@Lulalaby Lulalaby closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto Defer Support
5 participants