-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement auto defer #223
Implement auto defer #223
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: splatterxl <[email protected]>
Oh interesting, I had been thinking of adding it at the command / component level, but this is probably better yeah. I will do a deeper review when I have time, the badge launch has me a lil busy sorry! |
Always the badges smh Mr. Active Developer Badge 🤣 |
I also thought it would be on a per-command level like Ian said. I do like this, but maybe there should be an option to individually change it for some where you might not want to auto defer. |
Something like ignore global setting? |
I'd say add an auto defer option to commands as well, and let them set it to true/false. Easy to add or remove per command that way, and change it for all for reduced boilerplate. Best of both worlds |
okidoki, will do tmrw |
I wish I could finish it but I just don't have the time, so closing it. Maybe someone else would like to add it (I still think it'd be a cool feature) |
I'm not sure if I did it correctly. Open for feedback ❤️
Closes #222