-
Notifications
You must be signed in to change notification settings - Fork 31
♻️🐛 Use celery task manager in function job task client service #8352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️🐛 Use celery task manager in function job task client service #8352
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8352 +/- ##
===========================================
- Coverage 89.16% 68.93% -20.23%
===========================================
Files 1745 883 -862
Lines 68443 39551 -28892
Branches 832 175 -657
===========================================
- Hits 61024 27263 -33761
- Misses 7197 12231 +5034
+ Partials 222 57 -165
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
services/api-server/src/simcore_service_api_server/_service_function_jobs.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some minor things
services/api-server/src/simcore_service_api_server/_service_function_jobs_task_client.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/_service_function_jobs_task_client.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/_service_function_jobs_task_client.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/_service_function_jobs_task_client.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/_service_function_jobs_task_client.py
Show resolved
Hide resolved
services/api-server/tests/unit/api_functions/test_api_routers_function_jobs.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx a lot!
@Mergifyio queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
|
What do these changes do?
FunctionJobService
should depend on the Celery client. This is because e.g. the status of a function job now depends critically on celery: Before the backend project is created, the status of the job is essentially the status of the celery task which "is responsible" for creating the backend project.FunctionJobService
in the first place.FunctionJobService
in two: One part which only depends on the lower service layers of the api-server (jobs and studies) and a second part which in addition depends on the celery task client (TaskManager
). See also https://github.com/bisgaard-itis/osparc-simcore/blob/bugfix-use-celery-task-manager-in-function-job-service/services/api-server/docs/api-server.drawio.svg for detailsRelated issue/s
How to test
Dev-ops