-
Notifications
You must be signed in to change notification settings - Fork 31
✨ Adding generic scheduling capability to to dynamic-schduler [part 1/1] #8307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
✨ Adding generic scheduling capability to to dynamic-schduler [part 1/1] #8307
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8307 +/- ##
==========================================
- Coverage 87.38% 87.09% -0.30%
==========================================
Files 1951 1952 +1
Lines 75948 76550 +602
Branches 1337 1319 -18
==========================================
+ Hits 66364 66668 +304
- Misses 9185 9494 +309
+ Partials 399 388 -11
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…-dy-scheduler-part2
…-dy-scheduler-part2
…-dy-scheduler-part2
|
What do these changes do?
Please 🙏 don't panic, important changes are
1825 lines
. The remaining line changes are 99% tests.Focus your review starting from module:
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/
Suggested review order:
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_core.py
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_event_scheduler.py
TODO: finish this writeup
Related issue/s
How to test
Dev-ops