Skip to content

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Sep 4, 2025

What do these changes do?

Please 🙏 don't panic, important changes are 1825 lines. The remaining line changes are 99% tests.

Focus your review starting from module:

  • services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/

Suggested review order:

  • services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_core.py
  • services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_event_scheduler.py

TODO: finish this writeup

Related issue/s

How to test

Dev-ops

@GitHK GitHK self-assigned this Sep 4, 2025
@GitHK GitHK added this to the Cheops milestone Sep 4, 2025
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 96.06675% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.09%. Comparing base (8003f66) to head (e68622c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8307      +/-   ##
==========================================
- Coverage   87.38%   87.09%   -0.30%     
==========================================
  Files        1951     1952       +1     
  Lines       75948    76550     +602     
  Branches     1337     1319      -18     
==========================================
+ Hits        66364    66668     +304     
- Misses       9185     9494     +309     
+ Partials      399      388      -11     
Flag Coverage Δ
integrationtests 60.36% <ø> (-0.02%) ⬇️
unittests 86.56% <96.06%> (-0.03%) ⬇️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 83.58% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 93.09% <ø> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database 87.95% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 72.41% <ø> (ø)
pkg_settings_library 90.19% <ø> (ø)
pkg_simcore_sdk 84.93% <ø> (-0.06%) ⬇️
agent 93.53% <ø> (ø)
api_server 91.96% <ø> (ø)
autoscaling 95.78% <ø> (ø)
catalog 92.36% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 85.44% <ø> (+0.01%) ⬆️
dynamic_scheduler 96.17% <96.06%> (-0.11%) ⬇️
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.62% <ø> (ø)
resource_usage_tracker 92.13% <ø> (-0.11%) ⬇️
storage 86.66% <ø> (+0.12%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.96% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8003f66...e68622c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

mergify bot commented Sep 4, 2025

🧪 CI Insights

Here's what we observed from your CI run for e68622c.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Healthy 0 View View
system-tests Healthy 0 View View
unit-tests Healthy 0 View View

Copy link

@GitHK GitHK changed the title ✨ Adding generic scheduling capability to dynamic-schduler ✨ Adding generic scheduling capability to to dynamic-schduler [part 1/1] Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant