-
Notifications
You must be signed in to change notification settings - Fork 31
🐛Ensure locked state is shown when RTC_MAX_NUMBER_OF_USERS is set #8181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Ensure locked state is shown when RTC_MAX_NUMBER_OF_USERS is set #8181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
services/web/server/src/simcore_service_webserver/projects/_projects_service.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8181 +/- ##
==========================================
- Coverage 88.04% 85.33% -2.72%
==========================================
Files 1907 738 -1169
Lines 73277 33770 -39507
Branches 1302 176 -1126
==========================================
- Hits 64519 28818 -35701
+ Misses 8369 4894 -3475
+ Partials 389 58 -331
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
06ccb8f
to
9118d9e
Compare
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
9118d9e
to
a69eb71
Compare
|
What do these changes do?
ensure retrieved ProjectShareState lock status is correctly set when
RTC_MAX_NUMBER_OF_USERS
is setRelated issue/s
How to test
Dev-ops