Skip to content

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 31, 2025

What do these changes do?

ensure retrieved ProjectShareState lock status is correctly set when RTC_MAX_NUMBER_OF_USERS is set

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jul 31, 2025
@sanderegg sanderegg self-assigned this Jul 31, 2025
@sanderegg sanderegg added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jul 31, 2025
@sanderegg sanderegg requested a review from odeimaiz July 31, 2025 15:37
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.33%. Comparing base (b585dbf) to head (deceaa9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8181      +/-   ##
==========================================
- Coverage   88.04%   85.33%   -2.72%     
==========================================
  Files        1907      738    -1169     
  Lines       73277    33770   -39507     
  Branches     1302      176    -1126     
==========================================
- Hits        64519    28818   -35701     
+ Misses       8369     4894    -3475     
+ Partials      389       58     -331     
Flag Coverage Δ
integrationtests 64.32% <33.33%> (+0.01%) ⬆️
unittests 87.37% <91.66%> (+0.68%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.92% <ø> (-8.07%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.09% <ø> (-12.84%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.23% <ø> (-2.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.13% <91.66%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b585dbf...deceaa9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the bugfix/set-locked-state-based-on-RTC_MAX_NUMBER_OF_USERS branch from 06ccb8f to 9118d9e Compare July 31, 2025 16:30
@sanderegg sanderegg added 🤖-automerge marks PR as ready to be merged for Mergify and removed 🤖-automerge marks PR as ready to be merged for Mergify labels Jul 31, 2025
@sanderegg
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Jul 31, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@sanderegg sanderegg force-pushed the bugfix/set-locked-state-based-on-RTC_MAX_NUMBER_OF_USERS branch from 9118d9e to a69eb71 Compare July 31, 2025 19:06
@odeimaiz odeimaiz enabled auto-merge (squash) August 6, 2025 08:32
Copy link

sonarqubecloud bot commented Aug 6, 2025

@odeimaiz odeimaiz merged commit 4d35ed1 into ITISFoundation:master Aug 6, 2025
89 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 8, 2025
88 tasks
@sanderegg sanderegg deleted the bugfix/set-locked-state-based-on-RTC_MAX_NUMBER_OF_USERS branch August 11, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants