Skip to content

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jul 22, 2025

What do these changes do?

This PR removes the workbench column from the projects database table, completing the migration from storing node data in the projects table to the dedicated projects_nodes table. This is a major database schema change that required extensive refactoring throughout the codebase.

Removal of the workbench column from the projects table definition and migration of all node data to projects_nodes table
Replacement of direct workbench access with queries to projects_nodes table using a subquery pattern
Updates to all test fixtures and utilities to use the new projects_nodes based approach

image

Related issue/s

How to test

Dev-ops

@giancarloromeo giancarloromeo added this to the Engage milestone Jul 22, 2025
@giancarloromeo giancarloromeo self-assigned this Jul 22, 2025
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jul 22, 2025
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 58.11966% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.21%. Comparing base (dd684b7) to head (037272b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8141      +/-   ##
==========================================
- Coverage   87.89%   83.21%   -4.69%     
==========================================
  Files        1950     1950              
  Lines       75907    75995      +88     
  Branches     1336     1336              
==========================================
- Hits        66718    63236    -3482     
- Misses       8791    12361    +3570     
  Partials      398      398              
Flag Coverage Δ
integrationtests 63.19% <64.28%> (-0.71%) ⬇️
unittests 82.72% <58.11%> (-3.85%) ⬇️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 83.58% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 93.09% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.89% <66.66%> (-0.07%) ⬇️
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 72.59% <ø> (ø)
pkg_settings_library 90.19% <ø> (ø)
pkg_simcore_sdk 84.99% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 91.93% <ø> (ø)
autoscaling 95.77% <ø> (ø)
catalog 92.36% <100.00%> (-0.01%) ⬇️
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.81% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 85.34% <92.85%> (-5.59%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.13% <ø> (-0.16%) ⬇️
storage 86.72% <78.26%> (+0.18%) ⬆️
webclient ∅ <ø> (∅)
webserver 75.35% <49.43%> (-12.61%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd684b7...037272b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov assigned pcrespov and unassigned pcrespov Aug 22, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will review when ready

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-do-not-merge (optional) blocks Mergify from merging the PR a:webserver webserver's codebase. Assigning the area is particularly useful for bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants