Skip to content

Engine Refactor #1: Basic Structure #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Engine Refactor #1: Basic Structure #82

wants to merge 1 commit into from

Conversation

HazelYuAhiru
Copy link
Collaborator

@HazelYuAhiru HazelYuAhiru commented Oct 2, 2025 •
edited
Loading

This PR introduces a basic structure for the new query AST design. The structure can be divided into the following categories:

  • Class Node (abstract superclass for all nodes in the tree)
  • Specific tree nodes: TableNode, ColumnNode, etc.
  • Query structure nodes: SelectNode, FromNode, WhereNode, etc.

Todos (just for reference)

  • Refine the naming of files, classes, and fields as needed.
  • Simplify how specific children are retrieved from a parent node. Currently, this is done by index, which can be nested and confusing. We might consider implementing class methods that retrieve children based on identifiers or names.
  • Add scoping-related functionality. (after we have some unit tests)
  • Add Join-related functionality. (after we have some unit tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baiqiushi baiqiushi Awaiting requested review from baiqiushi

@colinthebomb1 colinthebomb1 Awaiting requested review from colinthebomb1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HazelYuAhiru