Skip to content

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Dec 10, 2025

What this PR does / why we need it: Per discussion related to #11916 in https://docs.google.com/spreadsheets/d/1yvpIgD5tTst2Momu3RnzihmeEMvYH-TgfKjF7cdmJwg/edit?gid=0#gid=0, the processing of the Other Identifier fields to create the DataCite XML export/submission to DataCite has a bug that causes the identifier type to be set to :unav even when it is available (the otherIdAgency field has a value). This PR fixes that issue.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this: Add entries for the two Other Identifier fields (otherIdAgency, otherIdValue) and verify that the DataCite XML output includes a section like

<alternateIdentifiers>
<alternateIdentifier alternateIdentifierType="{otherIdAgency}">{otherIdValue}</alternateIdentifier>
</alternateIdentifiers>

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: fairly minor issue to include

Additional documentation:

@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Dec 10, 2025
@qqmyers qqmyers moved this to Ready for Triage in IQSS Dataverse Project Dec 10, 2025
@coveralls
Copy link

Coverage Status

coverage: 24.23% (-0.001%) from 24.231%
when pulling ec56845 on GlobalDataverseCommunityConsortium:otherIdentifierBug
into 70b6e26 on IQSS:develop.

@scolapasta scolapasta moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Dec 16, 2025
@cmbz cmbz added FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) labels Dec 17, 2025
@cmbz cmbz added the FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) label Dec 31, 2025
@stevenwinship stevenwinship moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jan 8, 2026
@stevenwinship stevenwinship self-assigned this Jan 8, 2026

for (DatasetFieldCompoundValue otherIdentifier : otherIdentifiers) {
String identifierType = null;
String identifierType = ":unav";;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant semicolon. I'll approve it but feel free to remove it

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jan 8, 2026
@stevenwinship stevenwinship removed their assignment Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) FY26 Sprint 13 FY26 Sprint 13 (2025-12-17 - 2025-12-31) FY26 Sprint 14 FY26 Sprint 14 (2025-12-31 - 2026-01-14) Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: Ready for QA ⏩

Development

Successfully merging this pull request may close these issues.

4 participants