DD-2075: Hidden fields of a dataset creation form remain visible AND setting a field to 'hidden' is not working #11992 #12017
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Setting a field to 'hidden' is not working IQSS#11992
Contributor
|
@qqmyers : would you have a look at this? |
qqmyers
reviewed
Dec 4, 2025
| <ui:repeat value="#{metadataBlockVal.value}" var="dsf" varStatus="curField"> | ||
| <div class="form-group" role="group" | ||
| jsf:rendered="#{((editMode == 'METADATA' or dsf.datasetFieldType.shouldDisplayOnCreate() or !dsf.isEmpty() or dsf.required or dsf.hasRequiredChildren)) or (!datasetPage and dsf.include)}"> | ||
| jsf:rendered="#{((editMode == 'METADATA' or dsf.datasetFieldType.shouldDisplayOnCreate() or !dsf.isEmpty() or dsf.required or dsf.hasRequiredChildren) and dsf.include) or (!datasetPage and dsf.include)}"> |
Member
There was a problem hiding this comment.
I haven't tested but this seems odd - if dsf.isEmpty() is false (there is a value), we wouldn't display it if dsf.include is false? Should it be "or dsf.include" ?
Contributor
Author
There was a problem hiding this comment.
The fix was done here by comparing the statement with it before modification in 6.7 and set back 'and dsf.include' in the statement. To avoid any regression, nothing else is changed in this fix.
6.5
jsf:rendered="#{(
(editMode == 'METADATA' or dsf.datasetFieldType.displayOnCreate or !dsf.isEmpty() or dsf.required) and dsf.include)
or (!datasetPage and dsf.include)}">
6.7
jsf:rendered="#{(
(editMode == 'METADATA' or dsf.datasetFieldType.shouldDisplayOnCreate() or !dsf.isEmpty() or dsf.required or dsf.hasRequiredChildren))
or (!datasetPage and dsf.include)}">
fix:
jsf:rendered="#{(
(editMode == 'METADATA' or dsf.datasetFieldType.shouldDisplayOnCreate() or !dsf.isEmpty() or dsf.required or dsf.hasRequiredChildren) and dsf.include)
or (!datasetPage and dsf.include)}">
cmbz
added
FY26 Sprint 12
jggautier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DD-2075: Hidden fields of a dataset creation form remain visible AND setting a field to 'hidden' is not working #11992
What this PR does / why we need it:
We are in the process of upgrading to version 6.7.1.
While testing, I noticed that if I set a field (in this case from the citation block) to hidden, this does not apply.
These are the steps I followed:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: