881 notifications with paging #901
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cause 'isLoading' to flash on the NotificationsSection
github-actions
bot
added
FY26 Sprint 10
jp-tosca
reviewed
Jan 7, 2026
Contributor
jp-tosca
left a comment
jp-tosca
left a comment
There was a problem hiding this comment.
Made some comments, we also discussed that in the future we probably should create a mechanism for when a component makes an operation that may generate a notification it should trigger a refresh to check the most recent number of notifications, otherwise the user won't see the notifications until next update, not a big deal but probably would improve the user experience.
public/locales/en/account.json
Outdated
| "userGuideLinkText": "User Guide", | ||
| "demoServerLinkText": "Demo Site", | ||
| "clearAll": "Clear All", | ||
| "clearAllOnThisPage": "Clear Notifications", |
Contributor
There was a problem hiding this comment.
I know this may make sense in the context it is used but do you think it would be good to have a key: "description" that is closer in meaning? "Clear notifications" is specific, while "clearAllOnThisPage" is very vague. 🤔
| void (async () => { | ||
| await markAsRead(unreadIds) | ||
| setReadIds((prev) => [...prev, ...unreadIds]) | ||
| console.log('calling refetch after marking as read') |
| .filter((n) => !n.displayAsRead && !readIds.includes(n.id)) | ||
| .map((n) => n.id) | ||
|
|
||
| console.log('in useEffect, unreadIds:', unreadIds) |
jp-tosca
approved these changes
Jan 9, 2026
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds paging to Notifications UI
Which issue(s) this PR closes:
Special notes for your reviewer:
I created a separate "base branch" because 775 actually has all the commits for 775 and 881.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes or changelog update needed for this change?:
Additional documentation: