-
Notifications
You must be signed in to change notification settings - Fork 20
Fix Dataset and File Version Summaries #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issues in the dataset and file version displays, improving the logic for showing version differences and file version links, along with text and UI corrections.
- Enhanced logic for View Details button and file version linking based on deaccessioned status and datafile presence
- Improved display of file access changes (showing "Access: Restricted" instead of "isRestricted: true/false")
- Corrected and standardized error/informational messages across file versions
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sections/file/file-version/useFileVersionSummaryDescription.tsx | Removed early return for empty summary, allowing component to handle display logic |
| src/sections/file/file-version/FileVersions.tsx | Added logic to disable file version links when datafileId is missing and improved summary display with new conditions |
| src/sections/dataset/dataset-versions/view-difference/DatasetVersionsDifferenceTable.tsx | Enhanced display of file access changes to show human-readable text instead of boolean values |
| src/sections/dataset/dataset-versions/DatasetVersions.tsx | Improved View Details button logic to skip deaccessioned versions when finding previous version |
| src/files/domain/models/FileVersionSummaryInfo.ts | Added datafileId field to FileDifferenceSummary type |
| public/locales/en/file.json | Added "noVersions" message and removed unused "fileNotChange" key |
| public/locales/en/dataset.json | Simplified label from "File Metadata Changed" to "Metadata Changed" |
| tests/* | Added and updated tests for new functionality and removed obsolete tests |
| CHANGELOG.md | Documented changes in this release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ekraffmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a few comments 👍
|
Hi @ekraffmiller , thanks for your review! I just fixed them in my new commits. |
ekraffmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved!
|
@ekraffmiller Thanks for catching them. I solved these two
|
|
looks good! merging |






What this PR does / why we need it:
Dataset Page:
File Page
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Some screenshots of the issues are #879 here.
Comparing to JSF, see if the issues are solved
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes or changelog update needed for this change?:
yes
Additional documentation: