Skip to content

Conversation

@ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Oct 27, 2025

What this PR does / why we need it:

Dataset Page:

  • Dataset comparison summary t should be Access: Restricted
  • Deaccessioned reason font should not be bold
  • for the next version of a deaccessioned version, we still should have View Details button
  • Show View Details button if: 1. Current version is not deaccessioned 2. There is a previous non-deaccessioned version to compare with 3. Current version has a non-string summary (has actual changes)

File Page

  • If file not included, show text "File not included in this version"
  • remove link to dataset version if File not included in this version or deaccessioned without edit access

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Some screenshots of the issues are #879 here.
Comparing to JSF, see if the issues are solved

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

no

Is there a release notes or changelog update needed for this change?:

yes

Additional documentation:

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) GREI Re-arch GREI re-architecture-related labels Oct 27, 2025
@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Oct 27, 2025
@coveralls
Copy link

coveralls commented Oct 27, 2025

Coverage Status

coverage: 97.792% (-0.03%) from 97.817%
when pulling 415efec on Fix-File&Dataset-Version-Summaries
into 0416612 on develop.

@ChengShi-1 ChengShi-1 marked this pull request as ready for review October 27, 2025 21:19
@ChengShi-1 ChengShi-1 moved this to Ready for Review ⏩ in IQSS Dataverse Project Oct 27, 2025
@ChengShi-1 ChengShi-1 added the SPA label Oct 29, 2025
@ChengShi-1 ChengShi-1 requested a review from Copilot October 30, 2025 17:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issues in the dataset and file version displays, improving the logic for showing version differences and file version links, along with text and UI corrections.

  • Enhanced logic for View Details button and file version linking based on deaccessioned status and datafile presence
  • Improved display of file access changes (showing "Access: Restricted" instead of "isRestricted: true/false")
  • Corrected and standardized error/informational messages across file versions

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/sections/file/file-version/useFileVersionSummaryDescription.tsx Removed early return for empty summary, allowing component to handle display logic
src/sections/file/file-version/FileVersions.tsx Added logic to disable file version links when datafileId is missing and improved summary display with new conditions
src/sections/dataset/dataset-versions/view-difference/DatasetVersionsDifferenceTable.tsx Enhanced display of file access changes to show human-readable text instead of boolean values
src/sections/dataset/dataset-versions/DatasetVersions.tsx Improved View Details button logic to skip deaccessioned versions when finding previous version
src/files/domain/models/FileVersionSummaryInfo.ts Added datafileId field to FileDifferenceSummary type
public/locales/en/file.json Added "noVersions" message and removed unused "fileNotChange" key
public/locales/en/dataset.json Simplified label from "File Metadata Changed" to "Metadata Changed"
tests/* Added and updated tests for new functionality and removed obsolete tests
CHANGELOG.md Documented changes in this release

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ekraffmiller ekraffmiller self-assigned this Oct 31, 2025
@ekraffmiller ekraffmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Oct 31, 2025
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few comments 👍

@ChengShi-1
Copy link
Contributor Author

ChengShi-1 commented Nov 3, 2025

Hi @ekraffmiller , thanks for your review! I just fixed them in my new commits.

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Nov 4, 2025
@ekraffmiller ekraffmiller removed their assignment Nov 4, 2025
@cmbz cmbz added the FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) label Nov 5, 2025
@ekraffmiller ekraffmiller self-assigned this Nov 10, 2025
@ekraffmiller ekraffmiller moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Nov 10, 2025
@ekraffmiller
Copy link
Contributor

I found a discrepancy between JSF and SPA for Draft versions, after deaccessioning. (The text shown in the SPA should only be shown for published versions )
SPA:
Screenshot 2025-11-10 at 3 53 18 PM
JSF:
Screenshot 2025-11-10 at 3 54 03 PM

@ekraffmiller
Copy link
Contributor

If there are no details between versions, the "View Details" link appears, but when you click on it, there are no differences. For example, in this dataset, created multiple versions with no changes.
Screenshot 2025-11-10 at 4 06 53 PM
Screenshot 2025-11-10 at 4 07 01 PM

This is the same behavior as the JSF, but I think it could be more user friendly to show a message saying there are no differences, rather than a link to View Details.

@ekraffmiller ekraffmiller removed their assignment Nov 10, 2025
@ChengShi-1
Copy link
Contributor Author

@ekraffmiller Thanks for catching them. I solved these two

  • Remove View Detail button - the backend will still return an object, and some fields are undefined, so I added an additional check for it here useGetDatasetVersionDiff.ts
image
image

@ekraffmiller
Copy link
Contributor

looks good! merging

@ekraffmiller ekraffmiller merged commit 48dd9ff into develop Nov 12, 2025
13 of 16 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Nov 12, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request FY26 Sprint 9 FY26 Sprint 9 (2025-10-22 - 2025-11-05) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Fix: Dataset and File Version Summaries

5 participants