-
Notifications
You must be signed in to change notification settings - Fork 20
Dataset Type selection step in Create Dataset page #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
g-saracca
wants to merge
30
commits into
develop
Choose a base branch
from
797-dataset-type-selection-step
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: package-lock.json package.json
The DropdownButtonItem disabled property depends on it.
… and New Review button
…ry and its implementations
pdurbin
reviewed
Oct 21, 2025
src/sections/create-dataset/dataset-type-select/DatasetTypeSelect.tsx
Outdated
Show resolved
Hide resolved
pdurbin
reviewed
Oct 21, 2025
src/sections/create-dataset/dataset-type-select/DatasetTypeSelect.tsx
Outdated
Show resolved
Hide resolved
…ide click, focus, and escape key
Member
As I mentioned at standup I added the "waiting" label until we've addressed the above. I'll hold on to this issue. Thanks for the PR, @g-saracca! It looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY26 Sprint 8
FY26 Sprint 8 (2025-10-08 - 2025-10-22)
FY26 Sprint 9
FY26 Sprint 9 (2025-10-22 - 2025-11-05)
FY26 Sprint 10
FY26 Sprint 10 (2025-11-05 - 2025-11-19)
FY26 Sprint 11
FY26 Sprint 11 (2025-11-20 - 2025-12-03)
FY26 Sprint 12
FY26 Sprint 12 (2025-12-03 - 2025-12-17)
FY26 Sprint 13
FY26 Sprint 13 (2025-12-17 - 2025-12-31)
FY26 Sprint 14
FY26 Sprint 14 (2025-12-31 - 2026-01-14)
GREI Re-arch
GREI re-architecture-related
Waiting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following up on @pdurbin's work in #845, this PR updates how users select the dataset type in the dataset creation flow.
For now, we’ve hardcoded the dataset type descriptions (“dataset” and “review”) as a temporary solution until the new field is added.
This is the first step toward supporting dataset types in the SPA, more enhancements coming soon.
Storybook links:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Create Dataset Page, Dataset Type selector.

Edit Dataset Page, Dataset Type readonly field.

Is there a release notes or changelog update needed for this change?:
Not for now, might be good to add it after work related to dataset types is done.
Additional documentation: