Skip to content

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Sep 8, 2025

What this PR does / why we need it:

Replicates the JSF Dataset Templates functionality when creating a dataset.

Integrates with the new js-dataverse use case introduced in this PR.

Which issue(s) this PR closes:

Special notes for your reviewer:

I've also modified the SelectAdvanced component to accept options like { value: string, label: string } to improve flexibility about options and not just using the option value as option label.
I've also updated the dev-env/keycloak SPI and test-realm.json to match latest changes in the SPI and fix e2e tests.

Suggestions on how to test this:

*Note: there is a current backend issue but should not block this PR, the API is returning a permissions error when listing dataset templates for users without edit dataverse permissions, I've tested that PR and is working ok.

Step 1: Run the Development Environment

  1. Execute npm i.
  2. Navigate with cd packages/design-system && npm i && npm run build.
  3. Return with cd ../../.
  4. Ensure you have a .env file similar to .env.example
  5. Navigate with cd dev-env.
  6. Before running next step, be sure have a fresh unstable dataverse image.
  7. Start the environment using ./run-env.sh unstable .
  8. To verify the environment, visit http://localhost:8000/ and check your local Dataverse installation.

Step 2:
Dataset templates still need to be created through the JSF UI, so create templates in there and validate that they are integrated correctly in the SPA Create Dataset page.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

template-select

Is there a release notes update needed for this change?:

No

Additional documentation:

No

@github-actions github-actions bot added FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) FY26 Sprint 3 (2025-07-30 - 2025-08-13) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) GREI Re-arch GREI re-architecture-related SPA.Q3.2025.12 Dataset Templates SPA: Create Dataset Form labels Sep 8, 2025
@coveralls
Copy link

coveralls commented Sep 8, 2025

Coverage Status

coverage: 97.483% (-0.6%) from 98.052%
when pulling ed61156 on feat/745-dataset-templates-and-create-dataset-form
into 67c5773 on develop.

@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project Sep 8, 2025
@g-saracca g-saracca moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Sep 10, 2025
@g-saracca g-saracca removed their assignment Sep 10, 2025
@g-saracca g-saracca removed the Waiting label Sep 10, 2025
@ChengShi-1 ChengShi-1 self-assigned this Sep 10, 2025
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Sep 10, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! just a tiny detail, and I notice something is not related to template because it happens to all createDataset, we're missing Producer fields in the form. (EditDataset displays producer in a right way

JSF (sorry, please ignore the random text i type in =>
jsfversion
SPA=>
spaversion

Also, I didn't see e2e test for the templates, we could add a test case there as well

@g-saracca
Copy link
Contributor Author

Hi @ChengShi-1, yeah, not sure what is happening about the Producer field but is not coming from the API so that's why we are not render it, it's happening on beta also right now so something might have changed in the backend.
https://beta.dataverse.org/api/v1/dataverses/root/metadatablocks?onlyDisplayedOnCreate=true&returnDatasetFieldTypes=true

@g-saracca
Copy link
Contributor Author

All changes addressed 👌🏼

@g-saracca g-saracca removed their assignment Sep 12, 2025
@ChengShi-1 ChengShi-1 removed their assignment Sep 13, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, approving

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Sep 13, 2025
@cmbz cmbz added the FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) label Sep 14, 2025
@cmbz cmbz added the FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) label Sep 24, 2025
@ofahimIQSS ofahimIQSS self-assigned this Sep 26, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Sep 26, 2025
@ofahimIQSS
Copy link
Contributor

testing passed on my end. merging:

image

@ofahimIQSS ofahimIQSS merged commit 74d6b6a into develop Sep 29, 2025
10 of 12 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/745-dataset-templates-and-create-dataset-form branch September 29, 2025 16:03
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Sep 29, 2025
@ofahimIQSS ofahimIQSS removed their assignment Sep 29, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 26 FY25 Sprint 26 (2025-06-18 - 2025-07-02) FY26 Sprint 1 FY26 Sprint 1 (2025-07-02 - 2025-07-16) FY26 Sprint 2 FY26 Sprint 2 (2025-07-16 - 2025-07-30) FY26 Sprint 3 (2025-07-30 - 2025-08-13) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 7 FY26 Sprint 7 (2025-09-24 - 2025-10-08) GREI Re-arch GREI re-architecture-related Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: Create Dataset Form SPA.Q3.2025.12 Dataset Templates

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Create Dataset Form + Templates integration

6 participants