-
Notifications
You must be signed in to change notification settings - Fork 20
Create Dataset Form + Templates integration #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Dataset Form + Templates integration #820
Conversation
…n edit and create mode
…te fields are empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! just a tiny detail, and I notice something is not related to template because it happens to all createDataset, we're missing Producer fields in the form. (EditDataset displays producer in a right way
JSF (sorry, please ignore the random text i type in =>

SPA=>

Also, I didn't see e2e test for the templates, we could add a test case there as well
src/sections/shared/form/DatasetMetadataForm/MetadataFieldsHelper.ts
Outdated
Show resolved
Hide resolved
|
Hi @ChengShi-1, yeah, not sure what is happening about the Producer field but is not coming from the API so that's why we are not render it, it's happening on beta also right now so something might have changed in the backend. |
|
All changes addressed 👌🏼 |
ChengShi-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, approving

What this PR does / why we need it:
Replicates the JSF Dataset Templates functionality when creating a dataset.
Integrates with the new js-dataverse use case introduced in this PR.
Which issue(s) this PR closes:
Special notes for your reviewer:
I've also modified the
SelectAdvancedcomponent to accept options like { value: string, label: string } to improve flexibility about options and not just using the option value as option label.I've also updated the
dev-env/keycloakSPI andtest-realm.jsonto match latest changes in the SPI and fix e2e tests.Suggestions on how to test this:
*Note: there is a current backend issue but should not block this PR, the API is returning a permissions error when listing dataset templates for users without edit dataverse permissions, I've tested that PR and is working ok.
Step 1: Run the Development Environment
./run-env.sh unstable.Step 2:
Dataset templates still need to be created through the JSF UI, so create templates in there and validate that they are integrated correctly in the SPA Create Dataset page.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
No
Additional documentation:
No