Skip to content

Conversation

@ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Apr 23, 2025

What this PR does / why we need it:

We are missing showing the deaccession reason in the Dataset page.

Which issue(s) this PR closes:

Special notes for your reviewer:

js-dataverse version should be updated in package.json
waiting for IQSS/dataverse-client-javascript#292

Suggestions on how to test this:

Step 1: Run the Development Environment

Execute npm i.
Navigate with cd packages/design-system && npm i && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000/.
Navigate with cd dev-env.
Before running next step, be sure have a fresh unstable dataverse image.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000/ and check your local Dataverse installation.
Step 2: Test the feature

  1. Create a dataset
  2. publish it
  3. In edit dataset button, click deaccession the dataset with a deaccession reason
  4. check if the reason is shown
  5. also, check the version tab, check if the version has the deaccession reason included

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Screenshot 2025-04-22 at 7 40 27 PM Screenshot 2025-04-22 at 8 05 13 PM

Is there a release notes update needed for this change?:

Additional documentation:

@ChengShi-1 ChengShi-1 linked an issue Apr 23, 2025 that may be closed by this pull request
@github-actions github-actions bot added FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) FY25 Sprint 22 FY25 Sprint 22 (2025-04-23 - 2025-05-07) GREI Re-arch GREI re-architecture-related SPA.Q2 Not related to any specific Q2 feature SPA: Dataset page (View) labels Apr 23, 2025
@ChengShi-1 ChengShi-1 self-assigned this Apr 23, 2025
@ChengShi-1 ChengShi-1 moved this to In Progress 💻 in IQSS Dataverse Project Apr 23, 2025
@coveralls
Copy link

coveralls commented Apr 23, 2025

Coverage Status

coverage: 97.805% (-0.3%) from 98.07%
when pulling 6262512 on 656-dataset-page---show-deaccession-reason-and-info
into 4684edf on develop.

@ChengShi-1 ChengShi-1 moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Apr 23, 2025
@ChengShi-1 ChengShi-1 marked this pull request as ready for review April 23, 2025 21:39
@ChengShi-1 ChengShi-1 removed their assignment Apr 23, 2025
@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Apr 24, 2025
@g-saracca g-saracca moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 24, 2025
@g-saracca g-saracca self-assigned this Apr 24, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question and styling suggestion.

@g-saracca
Copy link
Contributor

@ChengShi-1 we have some merge conflicts

@ChengShi-1
Copy link
Contributor Author

@g-saracca Hi German, thanks for your review. Conflicts merged, and js-dataverse updated to newest alpha version.

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 28, 2025
@ofahimIQSS ofahimIQSS self-assigned this Apr 29, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 29, 2025
@ofahimIQSS
Copy link
Contributor

not really sure why but I keep getting a blank screen when I navigate to http://localhost:8000/spa

image

@ChengShi-1
Copy link
Contributor Author

not really sure why but I keep getting a blank screen when I navigate to http://localhost:8000/spa

image

@ofahimIQSS Hi Omer, I check this branch again and don't meet this situation. Could you please re-build the environment again see if it still happen?

  • Execute npm i
  • Navigate with cd dev-env. Before running next step, be sure have a fresh unstable dataverse image.
  • Start the environment using./run-env.sh unstable.
    and verify the environment,

@ofahimIQSS
Copy link
Contributor

looks good, merging.

@ofahimIQSS ofahimIQSS merged commit 66767e2 into develop Apr 30, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Apr 30, 2025
@ofahimIQSS ofahimIQSS deleted the 656-dataset-page---show-deaccession-reason-and-info branch April 30, 2025 13:16
@ofahimIQSS ofahimIQSS removed their assignment Apr 30, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) FY25 Sprint 22 FY25 Sprint 22 (2025-04-23 - 2025-05-07) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset page (View) SPA.Q2 Not related to any specific Q2 feature

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Dataset Page - Show deaccession reason and info

5 participants