-
Notifications
You must be signed in to change notification settings - Fork 20
Dataset page: show deaccession reason and info #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset page: show deaccession reason and info #664
Conversation
g-saracca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question and styling suggestion.
src/sections/dataset/dataset-versions/useDatasetVersionSummaryDescription.tsx
Outdated
Show resolved
Hide resolved
src/sections/dataset/dataset-versions/useDatasetVersionSummaryDescription.tsx
Outdated
Show resolved
Hide resolved
|
@ChengShi-1 we have some merge conflicts |
|
@g-saracca Hi German, thanks for your review. Conflicts merged, and js-dataverse updated to newest alpha version. |
|
not really sure why but I keep getting a blank screen when I navigate to http://localhost:8000/spa |
@ofahimIQSS Hi Omer, I check this branch again and don't meet this situation. Could you please re-build the environment again see if it still happen?
|
|
looks good, merging. |


What this PR does / why we need it:
We are missing showing the deaccession reason in the Dataset page.
Which issue(s) this PR closes:
Special notes for your reviewer:
js-dataverse version should be updated in package.json
waiting for IQSS/dataverse-client-javascript#292
Suggestions on how to test this:
Step 1: Run the Development Environment
Execute npm i.
Navigate with cd packages/design-system && npm i && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000/.
Navigate with cd dev-env.
Before running next step, be sure have a fresh unstable dataverse image.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000/ and check your local Dataverse installation.
Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: