Change the data format of File's creationDate and publishDate from Date to string #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
added
FY25 Sprint 12
g-saracca
requested changes
Dec 16, 2024
…ra return keyword
g-saracca
previously approved these changes
Dec 16, 2024
…-the-creation-date-and-publication-date-of-file
Contributor
|
lint / lint (push) Failing after 1m These 2 are failing and conflicts must be resolved. |
g-saracca
approved these changes
Dec 19, 2024
Contributor
|
Testing passed - merging PR |
ofahimIQSS
deleted the
560-feature-requestidea-show-a-string-for-the-creation-date-and-publication-date-of-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Change the e file creation date and publication date from Date object to string type(as same as the payload format) to avoid a date conflict
Which issue(s) this PR closes:
Special notes for your reviewer:
waiting for IQSS/dataverse-client-javascript#226 to be merged.
Once it merged, the
package.jsonshould be deleted and not merge into main branch.Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: