-
Notifications
You must be signed in to change notification settings - Fork 10
Use Case Creating Dataset Template #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
g-saracca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve left some comments and questions, and I have one more about where to place the “create template” use case. You might have noticed that I put the “get dataset templates” in the Datasets repository, what do you think we should do with this one? If we keep it here under Collections, it might be worth refactoring later to move the get dataset templates into the Collections repository as well? We could ask about this in the dv-core-spa channel.
g-saracca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
tests passing - merging |
What this PR does / why we need it:
Creates a template for a given Dataverse collection id.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Get dataset template places in datasetsRepository, but I place this to collection repository. I am not sure if I should put thi in dataset or collection repository, and I am open to move it to dataset repository if you think it's better
Suggestions on how to test this:
Is there a release notes or changelog update needed for this change?:
yes
Additional documentation: