Skip to content

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Aug 25, 2025

What this PR does / why we need it:

Adds 3 new use cases.

  1. Get External Tools
  2. Get Dataset Resolved External Tool
  3. Get File Resolved External Tool

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

This PR is ready but integration tests will fail until related dataverse PR is merged.

Suggestions on how to test this:

Code visual inspection and test passing.

Is there a release notes update needed for this change?:

No.

Additional documentation:

No

@github-actions github-actions bot added GREI Re-arch GREI re-architecture-related SPA.Q3.2025.10 External Tools: File Preview labels Aug 25, 2025
@g-saracca g-saracca marked this pull request as ready for review September 1, 2025 11:18
@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project Sep 1, 2025
@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Sep 1, 2025
@g-saracca g-saracca changed the title Feat/352 external tool use cases External Tools use cases Sep 1, 2025
@ChengShi-1 ChengShi-1 self-assigned this Sep 2, 2025
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Sep 2, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! just small suggestions about checking persistent id as a parameter

@ChengShi-1 ChengShi-1 added the FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) label Sep 2, 2025
ChengShi-1
ChengShi-1 previously approved these changes Sep 3, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for making the changes

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Sep 3, 2025
@g-saracca
Copy link
Contributor Author

Waiting on IQSS/dataverse#11760

@ofahimIQSS ofahimIQSS assigned ofahimIQSS and unassigned ofahimIQSS Sep 3, 2025
@g-saracca g-saracca moved this from Ready for QA ⏩ to In Progress 💻 in IQSS Dataverse Project Sep 4, 2025
@g-saracca g-saracca self-assigned this Sep 4, 2025
@g-saracca g-saracca moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Sep 10, 2025
@g-saracca g-saracca removed their assignment Sep 10, 2025
@g-saracca
Copy link
Contributor Author

@ChengShi-1 this is also ready for review now, related API PR was merged so I just solved merge conflicts and un-skip the tests 👍🏼

@ChengShi-1 ChengShi-1 self-assigned this Sep 10, 2025
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Sep 10, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Sep 10, 2025
@ChengShi-1 ChengShi-1 removed their assignment Sep 10, 2025
@ofahimIQSS
Copy link
Contributor

looks good to me - merging

@ofahimIQSS ofahimIQSS merged commit 585c419 into develop Sep 11, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Sep 11, 2025
@ofahimIQSS ofahimIQSS deleted the feat/352-external-tool-use-cases branch September 11, 2025 12:56
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q3.2025.10 External Tools: File Preview

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Create External Tool Use Cases

4 participants