-
Notifications
You must be signed in to change notification settings - Fork 10
External Tools use cases #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ChengShi-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! just small suggestions about checking persistent id as a parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for making the changes
|
Waiting on IQSS/dataverse#11760 |
|
@ChengShi-1 this is also ready for review now, related API PR was merged so I just solved merge conflicts and un-skip the tests 👍🏼 |
ChengShi-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
looks good to me - merging |
What this PR does / why we need it:
Adds 3 new use cases.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
This PR is ready but integration tests will fail until related dataverse PR is merged.
Suggestions on how to test this:
Code visual inspection and test passing.
Is there a release notes update needed for this change?:
No.
Additional documentation:
No