-
Notifications
You must be signed in to change notification settings - Fork 10
Add linkCollection, unlinkCollection and getCollectionLinks use cases #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, some comments and we need documentation about new use cases.
And we have some merge conflicts.
|
@g-saracca thanks for your review! I think I addressed everything. |
g-saracca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Approving!
|
Test passing - merging |
What this PR does / why we need it:
SPA Q3 Feature - Add Link and Unlink Collection features
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
This PR uses an API in the above pull request, need to wait for it to be merged first. Also, after the Dataverse PR is merged, need to change the Dataverse testing image back to unstable.
Suggestions on how to test this:
Review the test code, or test by creating your own linked collections and datasets in the UI, then run the API against that.
Is there a release notes update needed for this change?:
no
Additional documentation: