Change return type of getMyDataCollectionItems use case #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
SPA.Q2.1
g-saracca
reviewed
Jun 3, 2025
g-saracca
previously approved these changes
Jun 3, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
ofahimIQSS
moved this from Ready for QA ⏩
to Ready for Review ⏩
in IQSS Dataverse Project
Contributor
Author
|
Hi @g-saracca, I had to update the imports for PublicationStatus to get this to work in my frontend PR (IQSS/dataverse-frontend#737). It seems that including 'src' in the relative path doesn't cause a compile error, but causes an error when using the library. Can you review again please? (I also added PublicationStatus to the exports, but I'm not sure if I need to do that) |
g-saracca
previously approved these changes
Jun 4, 2025
Contributor
g-saracca
left a comment
g-saracca
left a comment
There was a problem hiding this comment.
@ekraffmiller, looks good and yes, you only need to export a type from the library if you need it from the consumer application. In the SPA side we have our own PublicationStatus enum, but anyways is ok if you leave that enum export
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
g-saracca
approved these changes
Jun 5, 2025
github-project-automation
bot
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
Contributor
|
Tests passing- merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update the return type of the use case so it more closely matches what is being returned by the API
Which issue(s) this PR closes:
Special notes for your reviewer:
Note that this is a breaking change, so it would be good to wait to merge this until the PR for the frontend change is ready also: IQSS/dataverse-frontend#734.
Suggestions on how to test this:
Review test code