Skip to content

return citationHtml instead of citation plain text #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofahimIQSS merged 2 commits into from
Jun 2, 2025
Merged

return citationHtml instead of citation plain text #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3d26ad
return citationHtml instead of citation plain text
g-saracca Jun 2, 2025
bcfdaf4
fix: tests
g-saracca Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/datasets/infra/repositories/transformers/DatasetPreviewPayload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export interface DatasetPreviewPayload {
updatedAt: string
published_at?: string
citation: string
citationHtml: string
description: string
type?: string
publicationStatuses: string[]
Expand Down
2 changes: 1 addition & 1 deletion src/datasets/infra/repositories/transformers/datasetPreviewsTransformers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const transformDatasetPreviewPayloadToDatasetPreview = (
releaseTime: new Date(datasetPreviewPayload.published_at)
})
},
citation: datasetPreviewPayload.citation,
citation: datasetPreviewPayload.citationHtml,
description: datasetPreviewPayload.description,
publicationStatuses: publicationStatuses,
parentCollectionAlias: datasetPreviewPayload.identifier_of_dataverse,
Expand Down
6 changes: 5 additions & 1 deletion test/testHelpers/datasets/datasetPreviewHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ const DATASET_RELEASE_TIME_STR = '2023-05-15T08:21:03Z'
const DATASET_CITATION =
'Doe, John, 2023, "Test Dataset 1", https://doi.org/10.5072/FK2/XXXXXX, Root, V1, UNF:6:AAc5A5tAI9AVodAAAsOysA== [fileUNF]'

const DATASET_CITATION_HTML =
'Finch, Fiona; Spruce, Sabrina; Poe, Edgar Allen; Mulligan, Hercules, 2019, "Darwin\'s Finches", <a href="https://doi.org/10.70122/FK2/MB5VGR" target="_blank">https://doi.org/10.70122/FK2/MB5VGR</a>, Root, V3'

export const createDatasetPreviewModel = (): DatasetPreview => {
const datasetPreviewModel: DatasetPreview = {
type: CollectionItemType.DATASET,
Expand All @@ -25,7 +28,7 @@ export const createDatasetPreviewModel = (): DatasetPreview => {
lastUpdateTime: new Date(DATASET_UPDATE_TIME_STR),
releaseTime: new Date(DATASET_RELEASE_TIME_STR)
},
citation: DATASET_CITATION,
citation: DATASET_CITATION_HTML,
description: 'test',
publicationStatuses: [PublicationStatus.Draft, PublicationStatus.Unpublished],
parentCollectionAlias: 'parentCollection',
Expand All @@ -47,6 +50,7 @@ export const createDatasetPreviewPayload = (): DatasetPreviewPayload => {
updatedAt: DATASET_UPDATE_TIME_STR,
published_at: DATASET_RELEASE_TIME_STR,
citation: DATASET_CITATION,
citationHtml: DATASET_CITATION_HTML,
description: 'test',
type: 'dataset',
publicationStatuses: ['Draft', 'Unpublished'],
Expand Down