Skip to content

Update deaccession note to the dataset #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofahimIQSS merged 2 commits into from
Apr 28, 2025
Merged

Update deaccession note to the dataset #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b425910
feat: update deaccession note
ChengShi-1 Apr 22, 2025
b0a1ddd
fix: add to dataHelper
ChengShi-1 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/datasets/domain/models/Dataset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export interface DatasetVersionInfo {
createTime: Date
lastUpdateTime: Date
releaseTime?: Date
deaccessionNote?: string
}

export enum DatasetVersionState {
Expand Down
1 change: 1 addition & 0 deletions src/datasets/infra/repositories/transformers/DatasetPayload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export interface DatasetPayload {
disclaimer?: string
files: FilePayload[]
isPartOf: OwnerNodePayload
deaccessionNote?: string
}

export interface LicensePayload {
Expand Down
3 changes: 2 additions & 1 deletion src/datasets/infra/repositories/transformers/datasetTransformers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,8 @@ export const transformVersionPayloadToDataset = (
state: versionPayload.versionState as DatasetVersionState,
createTime: new Date(versionPayload.createTime),
lastUpdateTime: new Date(versionPayload.lastUpdateTime),
releaseTime: new Date(versionPayload.releaseTime)
releaseTime: new Date(versionPayload.releaseTime),
deaccessionNote: versionPayload.deaccessionNote
},
termsOfUse: {
termsOfAccess: {
Expand Down
1 change: 1 addition & 0 deletions test/integration/datasets/DatasetsRepository.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,7 @@ describe('DatasetsRepository', () => {
const dataset = await sut.getDataset(testDatasetIds.numericId, '1.0', true, false)

expect(dataset.versionInfo.state).toBe('DEACCESSIONED')
expect(dataset.versionInfo.deaccessionNote).toBe(deaccessionDTO.deaccessionReason)
})

test('should return error when dataset is deaccessioned', async () => {
Expand Down
3 changes: 2 additions & 1 deletion test/testHelpers/datasets/datasetHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ export const createDatasetModel = (
state: DatasetVersionState.RELEASED,
createTime: new Date(DATASET_CREATE_TIME_STR),
lastUpdateTime: new Date(DATASET_UPDATE_TIME_STR),
releaseTime: new Date(DATASET_RELEASE_TIME_STR)
releaseTime: new Date(DATASET_RELEASE_TIME_STR),
deaccessionNote: undefined
},
termsOfUse: {
termsOfAccess: {
Expand Down