Implement use case for editing tabular tags and categories #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
changed the title
ChengShi-1
added
Size: 3
g-saracca
requested changes
Apr 22, 2025
| } | ||
| }) | ||
|
|
||
| test('should successfully update tabular tags of a file', async () => { |
Contributor
There was a problem hiding this comment.
For this use case and also for UpdateFileCategories, could you write a test that asserts that when using replace in false or undefined, the tags or categories are added and they don't replace existing ones? e.g.: Dataset had [a,b,c] categories and you send [d,e], now categories are [a,b,c,d,e].
Also what would hapen if dataset had ['a', 'b'] and you send ['b', 'c'], what will happen wih duplicated 'b'? I think we could add lot more test cases here so we are more confident for the integration in the SPA later 👍🏼
Contributor
Author
|
@g-saracca Hi German, changes made, please check again. Thanks for the review! |
g-saracca
approved these changes
Apr 22, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
tests are passing, merging |
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For a single file
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Additional documentation: