Skip to content

Conversation

@ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Apr 3, 2025

What this PR does / why we need it:

DatasetVersionDiff model, termsOfAccess should be {termsOfAccess?: changed: FieldDiff[] } from API

Previous PR Merged
197 compare dataset version #220

Related to
IQSS/dataverse-frontend#623

curl -H "X-Dataverse-key: $API_TOKEN" -X GET "$SERVER_URL/api/datasets/:persistentId/versions/2.0/compare/:draft?persistentId=$PERSISTENT_IDENTIFIER"

TermsOfAccess result could be

{
    "status": "OK",
    "data": {
        "oldVersion": {
            "versionNumber": "2.0",
            "versionState": "RELEASED",
            "lastUpdatedDate": "2025-04-02T05:35:36Z"
        },
        "newVersion": {
            "versionNumber": "DRAFT",
            "versionState": "DRAFT",
            "lastUpdatedDate": "2025-04-03T22:03:23Z"
        },
        "TermsOfAccess": {
            "changed": [
                {
                    "fieldName": "Terms of Access for Restricted Files",
                    "oldValue": "ertetre",
                    "newValue": "sgsgr"
                },
                {
                    "fieldName": "Data Access Place",
                    "oldValue": "",
                    "newValue": "qweqe"
                },
                {
                    "fieldName": "Original Archive",
                    "oldValue": "",
                    "newValue": "qwe"
                }
            ]
        }
    }
}

@ChengShi-1 ChengShi-1 added bug Something isn't working GREI Re-arch GREI re-architecture-related SPA.Q1.2 Dataset Page: Versions Tab FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) labels Apr 3, 2025
@ChengShi-1 ChengShi-1 changed the title Fix: change the modal of Fix: change the modal of DatasetVersionDiff Apr 3, 2025
@ChengShi-1 ChengShi-1 marked this pull request as ready for review April 3, 2025 21:21
@ChengShi-1
Copy link
Contributor Author

@g-saracca Hi German, there is a little tweak to DatasetVersionDiff model, in order to make this PR IQSS/dataverse-frontend#623 work. Could you help to check this?

@g-saracca
Copy link
Contributor

Looks ok, pretty simple, approving 👍

@ChengShi-1 ChengShi-1 moved this to Ready for QA ⏩ in IQSS Dataverse Project Apr 3, 2025
@g-saracca g-saracca changed the title Fix: change the modal of DatasetVersionDiff Fix: change the model of DatasetVersionDiff Apr 4, 2025
@ofahimIQSS ofahimIQSS self-assigned this Apr 7, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 7, 2025
@ofahimIQSS
Copy link
Contributor

tests are passing - merging PR

@ofahimIQSS ofahimIQSS merged commit b56897f into develop Apr 7, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Apr 7, 2025
@ofahimIQSS ofahimIQSS deleted the DatasetVersionDiffModelChange branch April 7, 2025 15:16
@ChengShi-1 ChengShi-1 added Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. labels Apr 7, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 8, 2025
@ofahimIQSS ofahimIQSS removed their assignment Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.2 Dataset Page: Versions Tab

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

4 participants