Compare Dataset Versions use case extension: add includeDeaccessioned option #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
FY25 Sprint 19
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
I see a review is pending from @ekraffmiller |
Contributor
Author
|
@ofahimIQSS , that is ok with Guillermo's review. |
Contributor
|
merging - looks good from my end. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For the Publish Dataset frontend feature, we need to compare the current release with the most recently published released, which may be deaccessioned. To support this we need to update the compare versions use case with the includeDeaccessioned parameter.
The version details will also be updated to include versionState. This is needed to implement the publish dataset logic - drafts that are published after a deaccessioned version must have a major version update.
Which issue(s) this PR closes:
Notes for your reviewer:
I also fix some wrong solved merge conflicts in a specific test and clean up datasets created during get download count tests.
Suggestions on how to test this:
Code review and check tests.