Skip to content

Conversation

@g-saracca
Copy link
Contributor

What this PR does / why we need it:

Returns the new file id number after replacing a file.

Suggestions on how to test this:

Code review and check that tests are passing.

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q1.6 Files Page: Files Edit Options FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) labels Mar 12, 2025
@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project Mar 12, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit change. We could also change the description of Replace a file in UseCases.md

@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 12, 2025
ChengShi-1
ChengShi-1 previously approved these changes Mar 12, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! approve

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Mar 12, 2025
@g-saracca g-saracca moved this from Ready for QA ⏩ to Ready for Review ⏩ in IQSS Dataverse Project Mar 13, 2025
@g-saracca g-saracca requested a review from ChengShi-1 March 13, 2025 19:40
@g-saracca
Copy link
Contributor Author

@ChengShi-1, I took the opportunity to make one more small change/fix to a directoryLabel property incorrectly mapped from js-dataverse.

@g-saracca g-saracca moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Mar 13, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me. approve

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Mar 14, 2025
@ofahimIQSS
Copy link
Contributor

tests passing - merging

@ofahimIQSS ofahimIQSS merged commit 79398c8 into develop Mar 21, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Mar 21, 2025
@ofahimIQSS ofahimIQSS deleted the feat/replce-file-return-info branch March 21, 2025 13:03
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.6 Files Page: Files Edit Options

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

4 participants