-
Notifications
You must be signed in to change notification settings - Fork 10
Return new file id after file replacement #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little bit change. We could also change the description of Replace a file in UseCases.md
ChengShi-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! approve
|
@ChengShi-1, I took the opportunity to make one more small change/fix to a directoryLabel property incorrectly mapped from js-dataverse. |
ChengShi-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to me. approve
|
tests passing - merging |
What this PR does / why we need it:
Returns the new file id number after replacing a file.
Suggestions on how to test this:
Code review and check that tests are passing.