Implement Use Case for dataset download count #274
Conversation
github-actions
bot
added
FY25 Sprint 18
ChengShi-1
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
ekraffmiller
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good! I just have some comments on allowing datasetId to be number | string and small text changes.
Co-authored-by: Ellen Kraffmiller <[email protected]>
…hub.com/IQSS/dataverse-client-javascript into 269-get-dataset-download-count-use-case
|
need an approval before this gets merged. |
|
@ekraffmiller hi ellen, the datasetid changes applied. please check again:) Thanks |
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
question about the change to docker-compose.yml
test/environment/docker-compose.yml
Outdated
| -Ddataverse.files.localstack1.access-key=default | ||
| -Ddataverse.files.localstack1.secret-key=default | ||
| ports: | ||
| - '8081:8080' |
There was a problem hiding this comment.
was this change just for your local environment? Can it be reverted?
There was a problem hiding this comment.
I forgot remove it, sorry. fixing now
There was a problem hiding this comment.
It seems like I reverted back to '8080:8080', pushed yesterday. I had a few commits yesterday, the latest one did this revert
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approving
github-project-automation
bot
moved this from QA ✅
to Ready for QA ⏩
in IQSS Dataverse Project
|
merging PR, tests are passing. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
What this PR does / why we need it:
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Inspect code and run tests
Is there a release notes update needed for this change?:
Additional documentation: