Skip to content

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Feb 13, 2025

What this PR does / why we need it:

Adds the Delete Collection use case.
I also add a query param by default to the Get Collection use case called childCount. This is needed to know if a collection has data in it, to only show the delete button when a collection has no data in it.

Which issue(s) this PR closes:

Related Dataverse PRs:

  • Depends on #11259.
    Once the above dataverse PR is merged we need to change test environment variables to use unstable and docker.io again.

Suggestions on how to test this:

Review code and tests.

@github-actions github-actions bot added FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) GREI Re-arch GREI re-architecture-related SPA.Q.1.7 Collection Page: Edit Collection > Delete Collection labels Feb 13, 2025
@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Feb 13, 2025
@ChengShi-1 ChengShi-1 self-assigned this Feb 13, 2025
@ChengShi-1 ChengShi-1 self-requested a review February 13, 2025 15:05
@ChengShi-1 ChengShi-1 removed their assignment Feb 13, 2025
@ChengShi-1 ChengShi-1 removed their request for review February 13, 2025 17:49
@g-saracca g-saracca self-assigned this Feb 13, 2025
@g-saracca g-saracca assigned ChengShi-1 and unassigned g-saracca Feb 13, 2025
@g-saracca
Copy link
Contributor Author

@ChengShi-1, ready for review again, thanks!

ChengShi-1
ChengShi-1 previously approved these changes Feb 18, 2025
@g-saracca g-saracca changed the title Feat/256 delete collection use case Delete Collection use case Feb 24, 2025
@g-saracca
Copy link
Contributor Author

g-saracca commented Feb 24, 2025

@ChengShi-1 , I update the branch with develop and set .env file back to using unstable image 👍🏼

Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, Approve

@ofahimIQSS
Copy link
Contributor

tests passing - merging PR

@ofahimIQSS ofahimIQSS merged commit 3446807 into develop Feb 24, 2025
5 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/256-delete-collection-use-case branch February 24, 2025 17:50
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q.1.7 Collection Page: Edit Collection > Delete Collection

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Delete Collection use case

4 participants