Skip to content

Conversation

@ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Feb 5, 2025

What this PR does / why we need it:

Reorganize TermsOfUse model in the Dataset so it groups custom terms and terms of access into separate objects

Which issue(s) this PR closes:

Suggestions on how to test this:

Review code and tests

Is there a release notes update needed for this change?:

Additional documentation:

@ekraffmiller ekraffmiller added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q1.3 Dataset Page: Terms Tab FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) labels Feb 5, 2025
@ekraffmiller ekraffmiller marked this pull request as draft February 6, 2025 17:08
@ekraffmiller ekraffmiller added the Size: 10 A percentage of a sprint. 7 hours. label Feb 10, 2025
@ekraffmiller ekraffmiller marked this pull request as ready for review February 10, 2025 13:43
@ekraffmiller ekraffmiller removed the Size: 10 A percentage of a sprint. 7 hours. label Feb 10, 2025
@g-saracca g-saracca self-assigned this Feb 10, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@g-saracca g-saracca removed their assignment Feb 10, 2025
@ofahimIQSS
Copy link
Contributor

reviewed code - tests are passing, merging PR

@ofahimIQSS ofahimIQSS closed this Feb 10, 2025
@ofahimIQSS ofahimIQSS reopened this Feb 10, 2025
@ofahimIQSS ofahimIQSS merged commit 15cdfa3 into develop Feb 10, 2025
5 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/251-refactor-terms-of-use branch February 10, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.3 Dataset Page: Terms Tab

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Get Dataset Terms of Use: refactoring Dataset Model

4 participants