Skip to content

Conversation

@ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented Jan 31, 2025

What this PR does / why we need it:

Inspired from this TODO as well as the 2025 Q1 proposal. The File edit option for single file could be implemented since the api endpoints are ready here.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Suggestions on how to test this:

Visually inspect and make sure that tests pass

Is there a release notes update needed for this change?:

Additional documentation:

@ChengShi-1 ChengShi-1 linked an issue Jan 31, 2025 that may be closed by this pull request
@ChengShi-1 ChengShi-1 self-assigned this Jan 31, 2025
@ChengShi-1 ChengShi-1 added Waiting SPA.Q1.6 Files Page: Files Edit Options Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 SPA: File Page GREI Re-arch GREI re-architecture-related FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) labels Feb 5, 2025
@ChengShi-1 ChengShi-1 removed their assignment Feb 13, 2025
@ChengShi-1 ChengShi-1 self-assigned this Feb 13, 2025
@ChengShi-1 ChengShi-1 force-pushed the 213-implement-use-case-for-edit-files-metadata-on-file-page branch from 02db5f7 to 2353a8f Compare February 24, 2025 14:43
@ChengShi-1 ChengShi-1 marked this pull request as ready for review February 24, 2025 18:10
@ChengShi-1 ChengShi-1 removed their assignment Feb 24, 2025
@cmbz cmbz added the FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) label Feb 26, 2025
@cmbz cmbz added the FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) label Feb 27, 2025
@g-saracca g-saracca moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Feb 27, 2025
@g-saracca g-saracca self-assigned this Feb 27, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good, just some minor comments.

@ChengShi-1
Copy link
Contributor Author

@g-saracca Hi German, I finish my updates in this PR, please check it again. Thanks!

g-saracca
g-saracca previously approved these changes Feb 28, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChengShi-1! Approving 👍🏼

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Feb 28, 2025
@ofahimIQSS
Copy link
Contributor

This PR has merge conflicts - please resolve so I can merge. Thank you!

Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving recent merge

@ofahimIQSS
Copy link
Contributor

merging PR

@ofahimIQSS ofahimIQSS merged commit 52f826c into develop Mar 5, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Mar 5, 2025
@ofahimIQSS ofahimIQSS deleted the 213-implement-use-case-for-edit-files-metadata-on-file-page branch March 5, 2025 19:53
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page SPA.Q1.6 Files Page: Files Edit Options

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Implement use case for edit files' metadata on file page

5 participants