Add OIDC Bearer Token Auth mechanism based on the PoC design #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
ekraffmiller
reviewed
Dec 3, 2024
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good! I just have a question about setting withCredentials
Contributor
|
Tests are passing - merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds OIDC Bearer Token Auth mechanism based on the PoC design.
Also adds a
RegisterUseruse case based on the new api endpoint added in IQSS/dataverse#10972Which issue(s) this PR closes:
Suggestions on how to test this:
This issue just adds a new mechanism to js-dataverse use cases, there is a unit test to check that the bearer token is being sent correctly in the Authorization header when configured with a bearer token.
Also a unit test for the RegisterUser use case has been added, more in-depth testing will be done on the SPA integration.