Display each document ingestion status for zip files #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lickem22
requested review from
sidravi1,
suzinyou,
amiraliemami,
markbotterill and
tonyzhao6
as code owners
ziakhan04
approved these changes
Apr 8, 2025
| export interface DocIndexingTask { | ||
| error_trace: string; | ||
| finished_datetime_utc: string; | ||
| upload_id: string; |
There was a problem hiding this comment.
General thought (I thought about this in my PR but just followed what has been going on in the project) -
It would be better organisation if we put all the types and interfaces in a file called schema/types (whatever you like). Similar to what happens in the backend and is also a convention in the front-end world as well. This keeps types and interfaces organised and only keeps the api functioning in the api module.
There was a problem hiding this comment.
I agree. Will make the change now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @ziakhan04
Estimate: 20mins
Ticket
Fixes: AAQ-915
Description
Goal
The goal of this PR is to display the status of ingestion of each document within a zip file as well as the status of the zip file.
Changes
How has this been tested?
Upload a zip file and check the information displayed on the modal.
Checklist
Fill with
xfor completed.