Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented version checking #191

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Conversation

ali-thowfeek
Copy link
Contributor

@ali-thowfeek ali-thowfeek commented Apr 15, 2020

Purpose

The purpose of this PR is to fix #179

Known issue

The code runs twice, as the widget gets initialized twice (even before the implementation of version checking). Thus two dialogs appear on top of the other.

It is another issue mentioned here #192

Work around

The issue is likely to be because of the the implementation of the DropdownBanner package. Because the following seems to fix it.

Change this:

MaterialApp(
//....
//....
home: DropdownBanner(
        child: HomeScreen(),
        navigatorKey: navigatorKey,
      ),
)

To:

MaterialApp(
//....
//....
home: HomeScreen(),
)

Notes

@dewmal Before merging, Please create and assign respective values for the following in the firebase console remote config:
android_app_builder_number_Key
ios_app_builder_number_key

known issue: the code runs twice, as the widget gets initialized twice (with or without this code for version checking)
@dewmal dewmal merged commit 063208f into ICTASL:master Apr 16, 2020
@ali-thowfeek ali-thowfeek deleted the pr/new-version-check branch May 3, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version checking.
2 participants