Repository Modernization Plan - Phase 2C: Fix typos and incorrect comments in idemix domain interfaces#71
Open
Soumya8898 wants to merge 1 commit into
Conversation
Soumya8898
force-pushed
the
Soumya8898/phase2/clean-idemix-interfaces
branch
from
50f104e to
e9ad80f
Compare
adecaro
force-pushed
the
Soumya8898/phase2/clean-idemix-interfaces
branch
from
e9ad80f to
0fecf11
Compare
Fix documentation errors in bccsp/types/: - idemix.go: Fix wrong type name in IssuerSecretKey comment - idemix.go: Fix misleading comment on NewKeyFromBytes (was 'NewPublicKeyFromBytes') - idemix.go: Fix double-space typo in Issuer.NewKeyFromBytes comment - idemix.go: Fix 'committments' typo (commitments) - idemix.go: Fix wrong type name in Credential interface comment (was 'CredRequest') - idemixerrs.go: Fix double-I typo in IdemixIssuerPublicKeyImporterErrorType Signed-off-by: Soumya Mohapatra <mohapatras@microsoft.com>
Soumya8898
force-pushed
the
Soumya8898/phase2/clean-idemix-interfaces
branch
from
0fecf11 to
a797fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typos and incorrect comments in idemix domain interfaces
Fixes #63
What
Fixes documentation errors and a type name typo in
bccsp/types/.Fixes in
bccsp/types/idemix.go// IssuerPublicKey is the issuer secret key// IssuerSecretKey is the issuer secret key// NewPublicKeyFromBytes converts the passed bytes to an Issuer key// NewKeyFromBytes converts the passed bytes to an Issuer secret key.the so obtained key(double space)the so obtained keycommittmentscommitments// CredRequest is a local interface...(on Credential type)// Credential is a local interface...Fixes in
bccsp/types/idemixerrs.goIdemixIIssuerPublicKeyImporterErrorType(double-I)IdemixIssuerPublicKeyImporterErrorTypeVerification
go build ./...✅go test ./...✅go vet ./...✅gofmt -l -s✅