Prototype - Support for configuartion of curve to use#20
Draft
mbwhite wants to merge 1 commit into
Draft
Conversation
8eaea94 to
b5c0194
Compare
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
b5c0194 to
51f116c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note PR for discussion of the approach (and being new to the codebase!)
idemixconfig.yamlis present (peer of the existing files read) read, and take the curve specified in there as the one that needs to be usednewhas moved tosetupBackward compatibility, if the file isn't there, or the field isn't there or known about, the original curve value is used.
Mathlib exports an enumeration for curveids, though these are ints - no ammenable to be used in a configuration file, therefore adopted a simple string naming. Ideally these should also be constants within mathlib
Signed-off-by: Matthew B White whitemat@uk.ibm.com