Conversation
Kornel-Toth
force-pushed
the
140-readme-example-tests
branch
2 times, most recently
from
e1bfc32 to
67288d5
Compare
mojito317
reviewed
Dec 10, 2025
Contributor
mojito317
left a comment
mojito317
left a comment
There was a problem hiding this comment.
Tests look good to me. I found some inconsistencies with the other SDKs.
| @@ -2,7 +2,7 @@ | |||
| You have created the document: | |||
Contributor
There was a problem hiding this comment.
Suggested change
| You have created the document: | |
| You have created the document. Response body: |
Comment on lines
4
to
7
| "_id": "example", | ||
| "_rev": "1-1b403633540686aa32d013fda9041a5d", | ||
| "name": "Bob Smith", | ||
| "joined": "2019-01-24T10:42:99.000Z" | ||
| "joined": "2019-01-24T10:42:59.000Z", | ||
| "rev": "1-1b403633540686aa32d013fda9041a5d" |
Contributor
There was a problem hiding this comment.
This should have id, rev and ok. According to https://github.com/IBM/cloudant-java-sdk/pull/788/files#diff-5addb27140ed743fa5d8bcd3a846a17289bc1abd2a75273cb3b094ad355ff2dd
| @@ -89,6 +89,6 @@ | |||
|
|
|||
| except ApiException as ae: | |||
Contributor
There was a problem hiding this comment.
Could you remove code from L84-L86? This has been done in the JS and Go examples as well.
test/examples/src/test_readme.py
Outdated
| wiremock_url = os.environ.get('WIREMOCK_URL') | ||
|
|
||
| # Reset WireMock scenarios | ||
| import requests |
Contributor
There was a problem hiding this comment.
Is this import needed to be here? If not, could you add the import to the other imports?
Kornel-Toth
force-pushed
the
140-readme-example-tests
branch
from
5c73e2f to
c4e046f
Compare
Kornel-Toth
force-pushed
the
140-readme-example-tests
branch
from
c4e046f to
f023e84
Compare
mojito317
approved these changes
Dec 11, 2025
Kornel-Toth
force-pushed
the
140-readme-example-tests
branch
from
f023e84 to
464879c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #921
What:
Why: