Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MF7 recipe to latest changes in ENDF-102 #4

Closed
wants to merge 232 commits into from

Conversation

marquezj
Copy link
Contributor

@marquezj marquezj commented May 8, 2024

Moved the PR to dev as requested in #3.

@gschnabel
Copy link
Collaborator

@marquezj Before I finally push the change to the dev branch, I would like to test the ENDF recipe extension on a file that uses the mixed coherent/incoherent representation and general information in MF7/MT451. Do you have an ENDF file handy that employs these options? I guess you can attach an ENDF file here to a new comment, but any other way of making it available to me is equally fine.

@marquezj
Copy link
Contributor Author

Oh, sorry. I just realized I made the PR from dev to your main.

Regarding the mixed elastic format, yes, we have many of them here:

https://github.com/highness-eu/NJOY-NCrystal-Library/tree/master/mixed_elastic

For instance, the mixed elastic evaluation for metallic aluminum:

https://github.com/highness-eu/NJOY-NCrystal-Library/blob/master/mixed_elastic/Al-006/tsl-Al_sg225_Aluminum-iel100.endf.tar.xz

The MF7/MT451 I do not have files in a repo yet, and I do not think there are files with this feature in open repositories (I have only seen them in the ENDF/B-VIII.1beta repository). But I can create a simple evaluation for test purposes.

I will reply to this thread when I have the file.

@marquezj
Copy link
Contributor Author

@gschnabel please find attached an example TSL file with the new sections, the NJOY processing script and the plots from the ACE file.

Al.zip
Al-006-00.pdf

@gschnabel
Copy link
Collaborator

All the suggested changes have been incorporated and TSL Al file added to to the testdata.

@gschnabel gschnabel closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants