Skip to content

feat(skybock): Add Skyblock item class and getSkyblockItems #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2025

Conversation

BonnetAdam
Copy link
Contributor

Changes

I've added SkyblockItem and getSkyblockItems

Checkboxes
  • I've added new features. (methods or parameters)
  • I've fixed bug. (optional you can mention a issue if there is one)
  • I've corrected the spelling in README, documentation, etc.
  • I've tested my code. (pnpm test)
  • I've check for issues. (pnpm lint)
  • I've fixed my formatting. (pnpm prettier)

Kathund

This comment was marked as outdated.

Copy link
Member

@Kathund Kathund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I added tests for you but you need to fix either them or your code. This is the error that is being thrown

 FAIL  src/API/getSkyblockItems.test.ts > getSkyblockItems
AssertionError: expected undefined to be defined
 ❯ src/API/getSkyblockItems.test.ts:35:27
     33|     expect(item.id).toBeDefined();
     34|     expectTypeOf(item.id).toEqualTypeOf<string>();
     35|     expect(item.category).toBeDefined();
       |                           ^
     36|     expectTypeOf(item.category).toEqualTypeOf<string>();
     37|     expect(item.npcSellPrice).toBeDefined();
 ❯ src/API/getSkyblockItems.test.ts:21:8

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 10, 2025
@Kathund Kathund merged commit 4122d40 into Hypixel-API-Reborn:master Mar 10, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants