SNS - Sensor Bounds Checking from Config #88
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will at some point get this to work. The goal is to (probably) create a macro of some kind that takes in the pod ID and measurement ID for each initialised sensor and uses them to a) validate that the pod ID and measurement ID are valid b) to generate the
calculate_boundsfunction using the limits in the config file.Not sure whether the sensors themselves need to know their IDs - probably not since the
read_*tasks will have logic for sending the resulting messages incl. IDs after reading from the sensors. We could therefore just create thecalculate_boundsfunctions in there anyway? May have just answered my own question there...